[PATCH] btrfs-progs: mkfs: remove experimental tag

[PATCH] btrfs-progs: mkfs: remove experimental tag

[David Sterba]

Make it consistent with kernel status and documentation.

Signed-off-by: David Sterba <dsterba@suse.cz>
---
 mkfs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mkfs.c b/mkfs.c
index 16e92221a547..538b6e6837b2 100644
--- a/mkfs.c
+++ b/mkfs.c
@@ -1439,8 +1439,8 @@ int main(int ac, char **av)
 	}
 
 	/* if we are here that means all devs are good to btrfsify */
-	printf("\nWARNING! - %s IS EXPERIMENTAL\n", BTRFS_BUILD_VERSION);
-	printf("WARNING! - see http://btrfs.wiki.kernel.org before using\n\n");
+	printf("%s\n", BTRFS_BUILD_VERSION);
+	printf("See http://btrfs.wiki.kernel.org for more\n\n");
 
 	dev_cnt--;
 
@@ -1597,7 +1597,6 @@ raid_groups:
 	    label, first_file, nodesize, leafsize, sectorsize,
 	    pretty_size(btrfs_super_total_bytes(root->fs_info->super_copy)));
 
-	printf("%s\n", BTRFS_BUILD_VERSION);
 	btrfs_commit_transaction(trans, root);
 
 	if (source_dir_set) {
-- 
1.9.0

Re: [PATCH] btrfs-progs: mkfs: remove experimental tag

[Satoru Takeuchi]

(2014/07/31 21:21), David Sterba wrote:
> Make it consistent with kernel status and documentation.
> 
> Signed-off-by: David Sterba <dsterba@suse.cz>

Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>

I'm glad to see this patch :-)

Thanks,
Satoru

> ---
>   mkfs.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/mkfs.c b/mkfs.c
> index 16e92221a547..538b6e6837b2 100644
> --- a/mkfs.c
> +++ b/mkfs.c
> @@ -1439,8 +1439,8 @@ int main(int ac, char **av)
>   	}
>   
>   	/* if we are here that means all devs are good to btrfsify */
> -	printf("\nWARNING! - %s IS EXPERIMENTAL\n", BTRFS_BUILD_VERSION);
> -	printf("WARNING! - see http://btrfs.wiki.kernel.org before using\n\n");
> +	printf("%s\n", BTRFS_BUILD_VERSION);
> +	printf("See http://btrfs.wiki.kernel.org for more\n\n");
>   
>   	dev_cnt--;
>   
> @@ -1597,7 +1597,6 @@ raid_groups:
>   	    label, first_file, nodesize, leafsize, sectorsize,
>   	    pretty_size(btrfs_super_total_bytes(root->fs_info->super_copy)));
>   
> -	printf("%s\n", BTRFS_BUILD_VERSION);
>   	btrfs_commit_transaction(trans, root);
>   
>   	if (source_dir_set) {
> 

RE: [PATCH] btrfs-progs: mkfs: remove experimental tag

[Kyle Gates]

----------------------------------------
> From: dsterba@suse.cz
> To: linux-btrfs@vger.kernel.org
> CC: dsterba@suse.cz
> Subject: [PATCH] btrfs-progs: mkfs: remove experimental tag
> Date: Thu, 31 Jul 2014 14:21:34 +0200
>
> Make it consistent with kernel status and documentation.
>
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
> mkfs.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/mkfs.c b/mkfs.c
> index 16e92221a547..538b6e6837b2 100644
> --- a/mkfs.c
> +++ b/mkfs.c
> @@ -1439,8 +1439,8 @@ int main(int ac, char **av)
> }
>
> /* if we are here that means all devs are good to btrfsify */
> - printf("\nWARNING! - %s IS EXPERIMENTAL\n", BTRFS_BUILD_VERSION);
> - printf("WARNING! - see http://btrfs.wiki.kernel.org before using\n\n");
> + printf("%s\n", BTRFS_BUILD_VERSION);
> + printf("See http://btrfs.wiki.kernel.org for more\n\n");

The sentence/thought isn't complete. I was left thinking "more what?"
perhaps add: information, documentation

Thanks.
>
> dev_cnt--;
>
> @@ -1597,7 +1597,6 @@ raid_groups:
> label, first_file, nodesize, leafsize, sectorsize,
> pretty_size(btrfs_super_total_bytes(root->fs_info->super_copy)));
>
> - printf("%s\n", BTRFS_BUILD_VERSION);
> btrfs_commit_transaction(trans, root);
>
> if (source_dir_set) {
> --
> 1.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
 		 	   		  

Re: [PATCH] btrfs-progs: mkfs: remove experimental tag

[David Sterba]

On Fri, Aug 01, 2014 at 11:38:09AM -0500, Kyle Gates wrote:
> The sentence/thought isn't complete. I was left thinking "more what?"
> perhaps add: information, documentation

Changed to 'more information'.