From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Lee Jones <lee.jones@linaro.org>, Samuel Ortiz <sameo@linux.intel.com>
Cc: David Collins <collinsd@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>,
Grant Likely <grant.likely@linaro.org>,
Courtney Cavin <courtney.cavin@sonymobile.com>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Josh Cartwright <joshc@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH v3 1/4] mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs
Date: Fri, 01 Aug 2014 11:31:29 +0300 [thread overview]
Message-ID: <53DB5061.8080403@mm-sol.com> (raw)
In-Reply-To: <53DA02C0.2050606@mm-sol.com>
On 07/31/2014 11:48 AM, Stanimir Varbanov wrote:
> Hi David,
>
> Thanks for the comments!
>
> On 07/30/2014 12:54 AM, David Collins wrote:
>> On 07/24/2014 05:45 AM, Stanimir Varbanov wrote:
>>> From: Josh Cartwright <joshc@codeaurora.org>
>>>
>>> The Qualcomm SPMI PMIC chips are components used with the
>>> Snapdragon 800 series SoC family. This driver exists
>>> largely as a glue mfd component, it exists to be an owner
>>> of an SPMI regmap for children devices described in
>>> device tree.
>>>
>>> Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
>>> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
>>> Acked-by: Lee Jones <lee.jones@linaro.org>
>>> ---
>>> drivers/mfd/Kconfig | 16 +++++++++++
>>> drivers/mfd/Makefile | 1 +
>>> drivers/mfd/pm8xxx-spmi.c | 65 +++++++++++++++++++++++++++++++++++++++++++++
>>
>> Would it be possible to rename this driver: qcom-spmi-pmic.c? The driver
>> will be supporting several PMICs that do not fit the pm8xxx naming scheme.
>> One of which is even specified in the compatible list of this driver
>> (pma8084). There is presently downstream support for the following PMICs:
>> PM8019, PM8110, PM8226, PM8841, PM8916, PM8941, PM8994, PMA8084, PMD9635,
>> PMI8962, and PMI8994 [1]. Four of these do not fit the "PM8XXX" template.
>
> I haven't strong opinion on the file names. The qcom prefix is the one
> which annoying me. If you look at /drivers/mfd the company name prefixes
> are very few.
>
> The *compatible* strings are the important thing here. So If MFD
> maintainer is fine with this name I'm fine too.
Lee, are you OK with suggested names qcom-spmi-pmic and qcom-ssbi-pmic?
--
regards,
Stan
WARNING: multiple messages have this Message-ID (diff)
From: svarbanov@mm-sol.com (Stanimir Varbanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs
Date: Fri, 01 Aug 2014 11:31:29 +0300 [thread overview]
Message-ID: <53DB5061.8080403@mm-sol.com> (raw)
In-Reply-To: <53DA02C0.2050606@mm-sol.com>
On 07/31/2014 11:48 AM, Stanimir Varbanov wrote:
> Hi David,
>
> Thanks for the comments!
>
> On 07/30/2014 12:54 AM, David Collins wrote:
>> On 07/24/2014 05:45 AM, Stanimir Varbanov wrote:
>>> From: Josh Cartwright <joshc@codeaurora.org>
>>>
>>> The Qualcomm SPMI PMIC chips are components used with the
>>> Snapdragon 800 series SoC family. This driver exists
>>> largely as a glue mfd component, it exists to be an owner
>>> of an SPMI regmap for children devices described in
>>> device tree.
>>>
>>> Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
>>> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
>>> Acked-by: Lee Jones <lee.jones@linaro.org>
>>> ---
>>> drivers/mfd/Kconfig | 16 +++++++++++
>>> drivers/mfd/Makefile | 1 +
>>> drivers/mfd/pm8xxx-spmi.c | 65 +++++++++++++++++++++++++++++++++++++++++++++
>>
>> Would it be possible to rename this driver: qcom-spmi-pmic.c? The driver
>> will be supporting several PMICs that do not fit the pm8xxx naming scheme.
>> One of which is even specified in the compatible list of this driver
>> (pma8084). There is presently downstream support for the following PMICs:
>> PM8019, PM8110, PM8226, PM8841, PM8916, PM8941, PM8994, PMA8084, PMD9635,
>> PMI8962, and PMI8994 [1]. Four of these do not fit the "PM8XXX" template.
>
> I haven't strong opinion on the file names. The qcom prefix is the one
> which annoying me. If you look at /drivers/mfd the company name prefixes
> are very few.
>
> The *compatible* strings are the important thing here. So If MFD
> maintainer is fine with this name I'm fine too.
Lee, are you OK with suggested names qcom-spmi-pmic and qcom-ssbi-pmic?
--
regards,
Stan
next prev parent reply other threads:[~2014-08-01 8:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 12:45 [PATCH v3 0/4] Support for Qualcomm QPNP PMIC's Stanimir Varbanov
2014-07-24 12:45 ` Stanimir Varbanov
2014-07-24 12:45 ` [PATCH v3 1/4] mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs Stanimir Varbanov
2014-07-24 12:45 ` Stanimir Varbanov
2014-07-29 21:54 ` David Collins
2014-07-29 21:54 ` David Collins
[not found] ` <53D8182A.5050204-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-07-31 8:48 ` Stanimir Varbanov
2014-07-31 8:48 ` Stanimir Varbanov
2014-07-31 8:48 ` Stanimir Varbanov
[not found] ` <53DA02C0.2050606-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-07-31 20:33 ` David Collins
2014-07-31 20:33 ` David Collins
2014-07-31 20:33 ` David Collins
2014-08-01 8:31 ` Stanimir Varbanov [this message]
2014-08-01 8:31 ` Stanimir Varbanov
2014-08-01 11:23 ` Lee Jones
2014-08-01 11:23 ` Lee Jones
2014-07-24 12:45 ` [PATCH v3 2/4] mfd: pm8xxx-spmi: document DT bindings " Stanimir Varbanov
2014-07-24 12:45 ` Stanimir Varbanov
2014-07-29 22:23 ` David Collins
2014-07-29 22:23 ` David Collins
[not found] ` <53D81EE1.7040309-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-07-31 8:58 ` Stanimir Varbanov
2014-07-31 8:58 ` Stanimir Varbanov
2014-07-31 8:58 ` Stanimir Varbanov
2014-07-31 20:53 ` David Collins
2014-07-31 20:53 ` David Collins
[not found] ` <1406205921-7452-1-git-send-email-svarbanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-07-24 12:45 ` [PATCH v3 3/4] ARM: dts: qcom: add pm8941 and pm8841 PMICs device nodes Stanimir Varbanov
2014-07-24 12:45 ` Stanimir Varbanov
2014-07-24 12:45 ` Stanimir Varbanov
2014-07-24 12:45 ` [PATCH v3 4/4] mfd: pm8921: rename pm8921-core driver Stanimir Varbanov
2014-07-24 12:45 ` Stanimir Varbanov
2014-07-28 14:20 ` [PATCH v3 0/4] Support for Qualcomm QPNP PMIC's Stanimir Varbanov
2014-07-28 14:20 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB5061.8080403@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=bjorn.andersson@sonymobile.com \
--cc=collinsd@codeaurora.org \
--cc=courtney.cavin@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joshc@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.