Re: [PATCH v5 00/10] ARM: dts: exynos: Prepare Spring

[Tomasz Figa <tomasz.figa@gmail.com>]

Hi Andreas,

On 01.08.2014 06:54, Andreas Färber wrote:
> Hello,
> 
> Based on the preinstalled 3.8 based ChromeOS kernel and previous 3.15 
> based attempts by Stephan and me that broke for 3.16, I've prepared a 
> device tree for the HP Chromebook 11 aka Google Spring.
> 
> v5 cleans up a regulator and the USB3503 hub and touches more 
> exynos5250 files.
> 
> Not yet enabled are trackpad, Wifi and sound.
> 
> My rebasing branch for testing is here:
> https://github.com/afaerber/linux/commits/spring-next
> 
> Regards,
> Andreas
> 
> v1 -> v2:
> * Dropped 3 documentation patches from series:
>   2 picked up,
>   https://patchwork.kernel.org/patch/4397271/
>   https://patchwork.kernel.org/patch/4397291/
>   1 already sent separately as v2, pending.
>   https://patchwork.kernel.org/patch/4424881/
> * Minimized and beautified Spring device tree and to some degree Snow as well.
>   See individual patches.
> 
> v2 -> v3:
> * Rebased: Two -cros-common cleanup patches were already applied
> * Lots of small cleanups for both Snow and Spring
> * Enabled I2S in Spring for symmetry
> * Added lid-switch and gpio-keys pinctrls to Spring
> 
> v3 -> v4:
> * Fixed pin-function 1 -> 0 for dp-hpd pinctrl, style cleanup
> 
> v4 -> v5:
> * Dropped regulator and fixed USB3503 for Spring
> * More cleanups, including SMDK5250 and Arndale
> 
> 
> Andreas Färber (10):
>   ARM: dts: Fix MMC pinctrl for exynos5250-snow
>   ARM: dts: Fold exynos5250-cros-common into exynos5250-snow
>   ARM: dts: Clean up exynos5250-snow
>   ARM: dts: Fill in bootargs for exynos5250-snow
>   ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow
>   ARM: dts: Clean up exynos5250-smdk5250
>   ARM: dts: Clean up exynos5250-arndale
>   ARM: dts: Fix apparent GPIO typo in exynos5250-arndale
>   ARM: dts: Simplify USB3503 on exynos5250-arndale
>   ARM: dts: Add exynos5250-spring device tree
> 
>  arch/arm/boot/dts/Makefile                    |   1 +
>  arch/arm/boot/dts/exynos5250-arndale.dts      | 927 +++++++++++++-------------
>  arch/arm/boot/dts/exynos5250-cros-common.dtsi | 164 -----
>  arch/arm/boot/dts/exynos5250-pinctrl.dtsi     |   7 -
>  arch/arm/boot/dts/exynos5250-smdk5250.dts     | 641 +++++++++---------
>  arch/arm/boot/dts/exynos5250-snow.dts         | 441 +++++++-----
>  arch/arm/boot/dts/exynos5250-spring.dts       | 536 +++++++++++++++
>  arch/arm/boot/dts/exynos5250.dtsi             |  24 +-
>  8 files changed, 1624 insertions(+), 1117 deletions(-)
>  delete mode 100644 arch/arm/boot/dts/exynos5250-cros-common.dtsi
>  create mode 100644 arch/arm/boot/dts/exynos5250-spring.dts
> 

I have looked through all the patches and they look good to me, so, for
the whole series:

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

There is one unrelated issue I reported in my reply to patch 7/10, but
it is more of a bug report, not a comment to your patch.

Best regards,
Tomasz