All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Townsend <martin.townsend@xsilon.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	linux-zigbee-devel@lists.sourceforge.net,
	linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Alexander Aring <alex.aring@gmail.com>
Subject: Re: [PATCH bluetooth-next] Simplify lowpan receive path so skb is freed in lowpan_rcv when dropped.
Date: Sat, 02 Aug 2014 07:42:02 +0100	[thread overview]
Message-ID: <53DC883A.1050304@xsilon.com> (raw)
In-Reply-To: <53DBB610.6020503@pengutronix.de>

I've just realised I've forgot to ensure skb_inout now points to the new 
skb when copy expanding.
Sorry about that, I'll respin the patch.

- Martin.

On 01/08/14 16:45, Marc Kleine-Budde wrote:
> On 08/01/2014 05:30 PM, Martin Townsend wrote:
>> Signed-off-by: Martin Townsend <martin.townsend@xsilon.com>
>> ---
>>   include/net/6lowpan.h         |  2 +-
>>   net/6lowpan/iphc.c            | 22 +++++++++++++---------
>>   net/bluetooth/6lowpan.c       | 12 ++++++++----
>>   net/ieee802154/6lowpan_rtnl.c | 12 ++++++------
>>   4 files changed, 28 insertions(+), 20 deletions(-)
>>
>> diff --git a/include/net/6lowpan.h b/include/net/6lowpan.h
>> index d7e9169..aa0381e 100644
>> --- a/include/net/6lowpan.h
>> +++ b/include/net/6lowpan.h
>> @@ -374,7 +374,7 @@ lowpan_uncompress_size(const struct sk_buff *skb, u16 *dgram_offset)
>>   
>>   typedef int (*skb_delivery_cb)(struct sk_buff *skb);
>>   
>> -int lowpan_process_data(struct sk_buff *skb, struct net_device *dev,
>> +int lowpan_process_data(struct sk_buff **skb_inout, struct net_device *dev,
> Why do you make the first parameter a double pointer?
>
> Marc
>

WARNING: multiple messages have this Message-ID (diff)
From: Martin Townsend <martin.townsend@xsilon.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	linux-zigbee-devel@lists.sourceforge.net,
	linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org
Cc: Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [Linux-zigbee-devel] [PATCH bluetooth-next] Simplify lowpan receive path so skb is freed in lowpan_rcv when dropped.
Date: Sat, 02 Aug 2014 07:42:02 +0100	[thread overview]
Message-ID: <53DC883A.1050304@xsilon.com> (raw)
In-Reply-To: <53DBB610.6020503@pengutronix.de>

I've just realised I've forgot to ensure skb_inout now points to the new 
skb when copy expanding.
Sorry about that, I'll respin the patch.

- Martin.

On 01/08/14 16:45, Marc Kleine-Budde wrote:
> On 08/01/2014 05:30 PM, Martin Townsend wrote:
>> Signed-off-by: Martin Townsend <martin.townsend@xsilon.com>
>> ---
>>   include/net/6lowpan.h         |  2 +-
>>   net/6lowpan/iphc.c            | 22 +++++++++++++---------
>>   net/bluetooth/6lowpan.c       | 12 ++++++++----
>>   net/ieee802154/6lowpan_rtnl.c | 12 ++++++------
>>   4 files changed, 28 insertions(+), 20 deletions(-)
>>
>> diff --git a/include/net/6lowpan.h b/include/net/6lowpan.h
>> index d7e9169..aa0381e 100644
>> --- a/include/net/6lowpan.h
>> +++ b/include/net/6lowpan.h
>> @@ -374,7 +374,7 @@ lowpan_uncompress_size(const struct sk_buff *skb, u16 *dgram_offset)
>>   
>>   typedef int (*skb_delivery_cb)(struct sk_buff *skb);
>>   
>> -int lowpan_process_data(struct sk_buff *skb, struct net_device *dev,
>> +int lowpan_process_data(struct sk_buff **skb_inout, struct net_device *dev,
> Why do you make the first parameter a double pointer?
>
> Marc
>


------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

  parent reply	other threads:[~2014-08-02  6:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 15:30 [PATCH bluetooth-next] Simplify lowpan receive path so skb is freed in lowpan_rcv when dropped Martin Townsend
2014-08-01 15:30 ` [Linux-zigbee-devel] " Martin Townsend
2014-08-01 15:45 ` Marc Kleine-Budde
2014-08-01 15:45   ` [Linux-zigbee-devel] " Marc Kleine-Budde
2014-08-01 15:56   ` Martin Townsend
2014-08-01 15:56     ` [Linux-zigbee-devel] " Martin Townsend
2014-08-02  6:42   ` Martin Townsend [this message]
2014-08-02  6:42     ` Martin Townsend

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DC883A.1050304@xsilon.com \
    --to=martin.townsend@xsilon.com \
    --cc=alex.aring@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=linux-zigbee-devel@lists.sourceforge.net \
    --cc=marcel@holtmann.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.