Re: [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow

[Tomasz Figa <tomasz.figa@gmail.com>]

On 02.08.2014 14:21, Tomasz Figa wrote:
> On 02.08.2014 02:52, Andreas Färber wrote:
>> Use the new style of referencing inherited nodes and use symbolic names.
>> Reorder one pinctrl node in GPIO order.
>>
>> Goal is the alignment of all exynos5250 based device trees for comparison.
>>
>> Suggested-by: Doug Anderson <dianders@chromium.org>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>  v5 -> v6:
>>  * Split off label additions (Doug Anderson)
>>  * Fixed alphabetical order of sd3_* nodes (Doug Anderson)
>>  
>>  v4 -> v5:
>>  * Introduced labels to consistently use new referencing style (Tomasz Figa)
>>  * Use IRQ_TYPE_* constants
>>  * Use some more GPIO_ACTIVE_*
>>
>>  v3 -> v4: Unchanged
>>  
>>  v3: New (Doug Anderson)
>>
>>  arch/arm/boot/dts/exynos5250-snow.dts | 291 +++++++++++++++++-----------------
>>  1 file changed, 145 insertions(+), 146 deletions(-)
> 
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Just for convenience of other reviewers, here are actual changes done do
the device tree after compiling into dtb and then back into dts:

> --- exynos5250-snow.dtb.dts	2014-08-02 14:54:15.145905921 +0200
> +++ ../dtbs.post/exynos5250-snow.dtb.dts	2014-08-02 14:54:15.146905921 +0200
> @@ -8,6 +8,7 @@
>  	model = "Google Snow";
>  
>  	chosen {
> +		bootargs = "console=tty1";
>  	};
>  
>  	aliases {
> @@ -829,15 +830,6 @@
>  			phandle = <0x44>;
>  		};
>  
> -		hdmi-hpd-irq {
> -			samsung,pins = "gpx3-7";
> -			samsung,pin-function = <0x0>;
> -			samsung,pin-pud = <0x1>;
> -			samsung,pin-drv = <0x0>;
> -			linux,phandle = <0x33>;
> -			phandle = <0x33>;
> -		};
> -
>  		max77686-irq {
>  			samsung,pins = "gpx3-2";
>  			samsung,pin-function = <0x0>;
> @@ -846,6 +838,15 @@
>  			linux,phandle = <0xe>;
>  			phandle = <0xe>;
>  		};
> +
> +		hdmi-hpd-irq {
> +			samsung,pins = "gpx3-7";
> +			samsung,pin-function = <0x0>;
> +			samsung,pin-pud = <0x1>;
> +			samsung,pin-drv = <0x0>;
> +			linux,phandle = <0x33>;
> +			phandle = <0x33>;
> +		};
>  	};
>  
>  	pinctrl@13400000 {
> @@ -1703,12 +1704,12 @@
>  		samsung,dw-mshc-ciu-div = <0x3>;
>  		samsung,dw-mshc-sdr-timing = <0x2 0x3>;
>  		samsung,dw-mshc-ddr-timing = <0x1 0x2>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <0x27 0x28 0x29>;
>  
>  		slot@0 {
>  			reg = <0x0>;
>  			bus-width = <0x4>;
> -			pinctrl-names = "default";
> -			pinctrl-0 = <0x27 0x28 0x29>;
>  		};
>  	};
>  

Best regards,
Tomasz