All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
Subject: Re: [Qemu-devel] [PATCH] virtio: Move extern declaration to header file
Date: Sat, 02 Aug 2014 17:31:26 +0400	[thread overview]
Message-ID: <53DCE82E.1050106@msgid.tls.msk.ru> (raw)
In-Reply-To: <1404760407-1554-1-git-send-email-sw@weilnetz.de>

07.07.2014 23:13, Stefan Weil wrote:
[]
> index 35316c4..ff4f200 100644
> --- a/hw/virtio/vhost-backend.c
> +++ b/hw/virtio/vhost-backend.c
> @@ -14,8 +14,6 @@
>  
>  #include <sys/ioctl.h>
>  
> -extern const VhostOps user_ops;
> -

BTW, it looks like we still have just one VhostOps - this user_ops one -
despite commit 24d1eb33eb2ccd995a which was aimed to add another ops
(kernel) back in May.  Maybe we should not add extra indirection without
a reason, before it is actually used?

Also, "user_ops" is way too generic name.  Maybe user_vhost_ops or something.

Just.. saying.

Thanks,

/mjt

      parent reply	other threads:[~2014-08-02 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-07 19:13 [Qemu-trivial] [PATCH] virtio: Move extern declaration to header file Stefan Weil
2014-07-07 19:13 ` [Qemu-devel] " Stefan Weil
2014-08-02 13:27 ` [Qemu-trivial] " Michael Tokarev
2014-08-02 13:27   ` [Qemu-devel] " Michael Tokarev
2014-08-02 13:31 ` Michael Tokarev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DCE82E.1050106@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=n.nikolaev@virtualopensystems.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.