ErasureCode base class

ErasureCode base class

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

Hi Andreas,

A short note to let you know I'm rebasing https://github.com/ceph/ceph/pull/1911 ( erasure-code: remapping for locally repairable codes ). I'll adapt the ISA plugin code accordingly, in particular for the new ErasureCode base class https://github.com/dachary/ceph/commit/82705f77d5b60653e8395ca3909c4564d9ac6825. This should be straightforward but if you have any reservation or warnings, I'm all ears ;-)

Cheers

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

ErasureCode base class

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi,

Would you have time to review the ErasureCode base class at https://github.com/ceph/ceph/pull/2201 ? It factorizes code that is common to ErasureCodeJerasure and ErasureCodeIsa. While doing so it really helped that you wrote the ErasureCodeIsa decode functions with only minimal changes compared to those in ErasureCodeJerasure. Thanks for that :-)

Cheers

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

RE: ErasureCode base class

[Andreas Joachim Peters]

Hi Loic, 
looks very good and removes all the duplication! 

I will then do the cache modification against this code base including this pull request.

Cheers Andreas.
________________________________________
From: Loic Dachary [loic@dachary.org]
Sent: 05 August 2014 09:53
To: Andreas Joachim Peters
Cc: Ceph Development
Subject: ErasureCode base class

Hi,

Would you have time to review the ErasureCode base class at https://github.com/ceph/ceph/pull/2201 ? It factorizes code that is common to ErasureCodeJerasure and ErasureCodeIsa. While doing so it really helped that you wrote the ErasureCodeIsa decode functions with only minimal changes compared to those in ErasureCodeJerasure. Thanks for that :-)

Cheers

--
Loïc Dachary, Artisan Logiciel Libre

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html