Re: [PATCH 6/7] MIPS: Malta: Fix dispatching of GIC interrupts

[Florian Fainelli <f.fainelli@gmail.com>]

On 07/17/2014 01:20 AM, Markos Chandras wrote:
> From: Jeffrey Deans <jeffrey.deans@imgtec.com>
> 
> The Malta malta_ipi_irqdispatch() routine now checks only IPI interrupts
> when handling IPIs. It could previously call do_IRQ() for non-IPIs, and
> also call do_IRQ() with an invalid IRQ number if there were no pending
> GIC interrupts when gic_get_int() was called.
> 
> Signed-off-by: Jeffrey Deans <jeffrey.deans@imgtec.com>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
>  arch/mips/mti-malta/malta-int.c | 25 ++++++++++++++++++-------
>  1 file changed, 18 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/mips/mti-malta/malta-int.c b/arch/mips/mti-malta/malta-int.c
> index 4ab919141737..e4f43baa8f67 100644
> --- a/arch/mips/mti-malta/malta-int.c
> +++ b/arch/mips/mti-malta/malta-int.c
> @@ -42,6 +42,10 @@ static unsigned int ipi_map[NR_CPUS];
>  
>  static DEFINE_RAW_SPINLOCK(mips_irq_lock);
>  
> +#ifdef CONFIG_MIPS_GIC_IPI
> +DECLARE_BITMAP(ipi_ints, GIC_NUM_INTRS);
> +#endif

I caught this one too late (it is already in mips-for-linux-next), but
it looks like we could make ipi_ints static.
--
Florian