All of lore.kernel.org
 help / color / mirror / Atom feed
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: eddie.dong@intel.com, kevin.tian@intel.com, keir@xen.org,
	jun.nakajima@intel.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: Use #defines instead of magic constants in vmx_vmcs_save()
Date: Tue, 05 Aug 2014 15:26:48 +0300	[thread overview]
Message-ID: <53E0CD88.30903@bitdefender.com> (raw)
In-Reply-To: <53E0E47C0200007800029706@mail.emea.novell.com>

On 08/05/2014 03:04 PM, Jan Beulich wrote:
>>>> On 05.08.14 at 11:57, <rcojocaru@bitdefender.com> wrote:
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -434,7 +434,8 @@ static void vmx_vmcs_save(struct vcpu *v, struct hvm_hw_cpu *c)
>>      c->error_code = 0;
>>      __vmread(VM_ENTRY_INTR_INFO, &ev);
>>      if ( (ev & INTR_INFO_VALID_MASK) &&
>> -         hvm_event_needs_reinjection((ev >> 8) & 7, ev & 0xff) )
>> +         hvm_event_needs_reinjection(MASK_EXTR(ev, INTR_INFO_INTR_TYPE_MASK),
>> +            ev & INTR_INFO_VECTOR_MASK) )
> 
> Broken indentation, but I guess I can fix this up while committing
> unless the VMX maintainers dislike the change and don't give their
> ack.

No worries, I've sent V2:

http://lists.xen.org/archives/html/xen-devel/2014-08/msg00471.html

Hope it's right this time.


Thanks,
Razvan Cojocaru

      reply	other threads:[~2014-08-05 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05  9:57 [PATCH] xen: Use #defines instead of magic constants in vmx_vmcs_save() Razvan Cojocaru
2014-08-05 12:04 ` Jan Beulich
2014-08-05 12:26   ` Razvan Cojocaru [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E0CD88.30903@bitdefender.com \
    --to=rcojocaru@bitdefender.com \
    --cc=JBeulich@suse.com \
    --cc=eddie.dong@intel.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir@xen.org \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.