From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
weidong.huang@huawei.com, stefanha@redhat.com, mst@redhat.com,
qemu-trivial <qemu-trivial@nongnu.org>,
marcel.a@redhat.com, luonengjun@huawei.com, armbru@redhat.com,
lcapitulino@redhat.com, av1474@comtv.ru, kraxel@redhat.com,
aliguori@amazon.com, imammedo@redhat.com, dmitry@daynix.com,
pbonzini@redhat.com, peter.huangpeng@huawei.com,
afaerber@suse.de, dgilbert@redhat.com
Subject: Re: [Qemu-trivial] [PATCH v4 0/8] don't use Yoda conditions
Date: Tue, 05 Aug 2014 07:01:21 -0600 [thread overview]
Message-ID: <53E0D5A1.1060801@redhat.com> (raw)
In-Reply-To: <1407143992-9248-1-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On 08/04/2014 03:19 AM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> $WHATEVER: don't use 'Yoda conditions'
>
> 'Yoda conditions' are not part of idiomatic QEMU coding
> style, so rewrite them in the more usual order.
>
> v4:
> - trivial typo for patch 1/8 suggested by Eric, thanks.
Series: Reviewed-by: Eric Blake <eblake@redhat.com>
Adding qemu-trivial in cc.
> Gonglei (8):
> CODING_STYLE: Section about conditional statement
> usb: don't use 'Yoda conditions'
> audio: don't use 'Yoda conditions'
> isa-bus: don't use 'Yoda conditions'
> don't use 'Yoda conditions'
> spice: don't use 'Yoda conditions'
> vl: don't use 'Yoda conditions'
> vmxnet3: don't use 'Yoda conditions'
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
weidong.huang@huawei.com, stefanha@redhat.com, mst@redhat.com,
qemu-trivial <qemu-trivial@nongnu.org>,
marcel.a@redhat.com, luonengjun@huawei.com, armbru@redhat.com,
lcapitulino@redhat.com, av1474@comtv.ru, kraxel@redhat.com,
aliguori@amazon.com, imammedo@redhat.com, dmitry@daynix.com,
pbonzini@redhat.com, peter.huangpeng@huawei.com,
afaerber@suse.de, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 0/8] don't use Yoda conditions
Date: Tue, 05 Aug 2014 07:01:21 -0600 [thread overview]
Message-ID: <53E0D5A1.1060801@redhat.com> (raw)
In-Reply-To: <1407143992-9248-1-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On 08/04/2014 03:19 AM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> $WHATEVER: don't use 'Yoda conditions'
>
> 'Yoda conditions' are not part of idiomatic QEMU coding
> style, so rewrite them in the more usual order.
>
> v4:
> - trivial typo for patch 1/8 suggested by Eric, thanks.
Series: Reviewed-by: Eric Blake <eblake@redhat.com>
Adding qemu-trivial in cc.
> Gonglei (8):
> CODING_STYLE: Section about conditional statement
> usb: don't use 'Yoda conditions'
> audio: don't use 'Yoda conditions'
> isa-bus: don't use 'Yoda conditions'
> don't use 'Yoda conditions'
> spice: don't use 'Yoda conditions'
> vl: don't use 'Yoda conditions'
> vmxnet3: don't use 'Yoda conditions'
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-08-05 19:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 9:19 [Qemu-devel] [PATCH v4 0/8] don't use Yoda conditions arei.gonglei
2014-08-04 9:19 ` [Qemu-devel] [PATCH v4 1/8] CODING_STYLE: Section about conditional statement arei.gonglei
2014-08-04 9:19 ` [Qemu-devel] [PATCH v4 2/8] usb: don't use 'Yoda conditions' arei.gonglei
2014-08-04 9:19 ` [Qemu-devel] [PATCH v4 3/8] audio: " arei.gonglei
2014-08-04 9:19 ` [Qemu-devel] [PATCH v4 4/8] isa-bus: " arei.gonglei
2014-08-04 9:19 ` [Qemu-devel] [PATCH v4 5/8] " arei.gonglei
2014-08-04 9:19 ` [Qemu-devel] [PATCH v4 6/8] spice: " arei.gonglei
2014-08-04 9:19 ` [Qemu-devel] [PATCH v4 7/8] vl: " arei.gonglei
2014-08-04 9:19 ` [Qemu-devel] [PATCH v4 8/8] vmxnet3: " arei.gonglei
2014-08-05 13:01 ` Eric Blake [this message]
2014-08-05 13:01 ` [Qemu-devel] [PATCH v4 0/8] don't use Yoda conditions Eric Blake
2014-08-06 1:25 ` [Qemu-trivial] " Gonglei (Arei)
2014-08-06 1:25 ` [Qemu-devel] " Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E0D5A1.1060801@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=av1474@comtv.ru \
--cc=dgilbert@redhat.com \
--cc=dmitry@daynix.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=luonengjun@huawei.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.