From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit@irqsave.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 5/7] block/qcow2: Make get_refcount() global
Date: Tue, 05 Aug 2014 07:18:10 -0600 [thread overview]
Message-ID: <53E0D992.70904@redhat.com> (raw)
In-Reply-To: <1406936961-20356-6-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
On 08/01/2014 05:49 PM, Max Reitz wrote:
> Reading the refcount of a cluster is an operation which can be useful in
> all of the qcow2 code, so make that function globally available.
>
> While touching this function, amend the comment describing the "addend"
> parameter: It is (no longer, if it ever was) necessary to have it set to
> -1 or 1; any value is fine.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/qcow2-refcount.c | 26 +++++++++++++-------------
> block/qcow2.h | 2 ++
> 2 files changed, 15 insertions(+), 13 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-08-05 13:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 23:49 [Qemu-devel] [PATCH v2 0/7] block/qcow2: Improve zero cluster expansion Max Reitz
2014-08-01 23:49 ` [Qemu-devel] [PATCH v2 1/7] block: Add status callback to bdrv_amend_options() Max Reitz
2014-08-04 9:19 ` Benoît Canet
2014-08-05 13:03 ` Eric Blake
2014-08-15 11:10 ` Benoît Canet
2014-08-01 23:49 ` [Qemu-devel] [PATCH v2 2/7] qemu-img: Add progress output for amend Max Reitz
2014-08-04 9:21 ` Benoît Canet
2014-08-05 13:04 ` Eric Blake
2014-08-15 11:18 ` Benoît Canet
2014-08-15 13:06 ` Max Reitz
2014-08-15 13:30 ` Benoît Canet
2014-08-01 23:49 ` [Qemu-devel] [PATCH v2 3/7] qemu-img: Fix insignificant memleak Max Reitz
2014-08-01 23:49 ` [Qemu-devel] [PATCH v2 4/7] block/qcow2: Implement status CB for amend Max Reitz
2014-08-04 9:29 ` Benoît Canet
2014-08-05 13:11 ` Eric Blake
2014-08-15 11:26 ` Benoît Canet
2014-08-01 23:49 ` [Qemu-devel] [PATCH v2 5/7] block/qcow2: Make get_refcount() global Max Reitz
2014-08-04 9:31 ` Benoît Canet
2014-08-05 13:18 ` Eric Blake [this message]
2014-08-15 11:27 ` Benoît Canet
2014-08-01 23:49 ` [Qemu-devel] [PATCH v2 6/7] block/qcow2: Simplify shared L2 handling in amend Max Reitz
2014-08-04 9:32 ` Benoît Canet
2014-08-05 13:27 ` Eric Blake
2014-08-15 11:50 ` Benoît Canet
2014-08-01 23:49 ` [Qemu-devel] [PATCH v2 7/7] iotests: Expand test 061 Max Reitz
2014-08-05 13:28 ` Eric Blake
2014-08-15 11:52 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E0D992.70904@redhat.com \
--to=eblake@redhat.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.