All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan_Lynch@mentor.com (Nathan Lynch)
To: linux-arm-kernel@lists.infradead.org
Subject: [Regression] FEC: Panic on suspend in 3.16
Date: Wed, 6 Aug 2014 10:43:19 -0500	[thread overview]
Message-ID: <53E24D17.90704@mentor.com> (raw)
In-Reply-To: <53E24A99.2020604@denx.de>

On 08/06/2014 10:32 AM, Stefano Babic wrote:
> Hi Nathan, Martin,
> 
> On 06/08/2014 17:09, Nathan Lynch wrote:
>> On 08/06/2014 09:52 AM, Martin Fuzzey wrote:
>>> Hi all,
>>>
>>> I am using the fec ethernet driver on a i.MX53 SoC.
>>>
>>> All was working fine on 3.13 but, after upgrading to 3.16 I now get a
>>> panic on suspend:
>>
>> Same issue reported here:
>>
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/277728.html
>>
>> a71e3c37960c (net: phy: Set the driver when registering an MDIO bus
>> device) has been implicated; try reverting that.
>>
> 
> I confirm this issue (on a i.MX35). The ndev pointer is NULL in the
> suspend function. I added the check for the pointer:

I'm not sure this is the right fix.  The fec driver's suspend function
is being called for a device it did not probe (I verified this on mx6q).

See Russell's explanation here:

http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/277823.html

WARNING: multiple messages have this Message-ID (diff)
From: Nathan Lynch <Nathan_Lynch@mentor.com>
To: Stefano Babic <sbabic@denx.de>
Cc: Martin Fuzzey <mfuzzey@parkeon.com>, <netdev@vger.kernel.org>,
	<festevam@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Regression] FEC: Panic on suspend in 3.16
Date: Wed, 6 Aug 2014 10:43:19 -0500	[thread overview]
Message-ID: <53E24D17.90704@mentor.com> (raw)
In-Reply-To: <53E24A99.2020604@denx.de>

On 08/06/2014 10:32 AM, Stefano Babic wrote:
> Hi Nathan, Martin,
> 
> On 06/08/2014 17:09, Nathan Lynch wrote:
>> On 08/06/2014 09:52 AM, Martin Fuzzey wrote:
>>> Hi all,
>>>
>>> I am using the fec ethernet driver on a i.MX53 SoC.
>>>
>>> All was working fine on 3.13 but, after upgrading to 3.16 I now get a
>>> panic on suspend:
>>
>> Same issue reported here:
>>
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/277728.html
>>
>> a71e3c37960c (net: phy: Set the driver when registering an MDIO bus
>> device) has been implicated; try reverting that.
>>
> 
> I confirm this issue (on a i.MX35). The ndev pointer is NULL in the
> suspend function. I added the check for the pointer:

I'm not sure this is the right fix.  The fec driver's suspend function
is being called for a device it did not probe (I verified this on mx6q).

See Russell's explanation here:

http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/277823.html

  reply	other threads:[~2014-08-06 15:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06 14:52 [Regression] FEC: Panic on suspend in 3.16 Martin Fuzzey
2014-08-06 14:52 ` Martin Fuzzey
2014-08-06 15:09 ` Nathan Lynch
2014-08-06 15:09   ` Nathan Lynch
2014-08-06 15:32   ` Stefano Babic
2014-08-06 15:32     ` Stefano Babic
2014-08-06 15:43     ` Nathan Lynch [this message]
2014-08-06 15:43       ` Nathan Lynch
2014-08-06 15:47     ` Russell King - ARM Linux
2014-08-06 15:47       ` Russell King - ARM Linux
2014-08-06 15:52       ` Stefano Babic
2014-08-06 15:52         ` Stefano Babic
2014-08-06 16:01       ` Fabio Estevam
2014-08-06 16:01         ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E24D17.90704@mentor.com \
    --to=nathan_lynch@mentor.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.