Re: [PATCH] rbd: allocate img_request with GFP_NOIO instead GFP_ATOMIC

[Alex Elder <elder@ieee.org>]

On 08/07/2014 04:40 AM, Ilya Dryomov wrote:
> Now that rbd_img_request_create() is called from work functions, no
> need to use GFP_ATOMIC.
> 
> Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>

Looks good.

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
>  drivers/block/rbd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 4515b128d0b4..a5ebcf28e041 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -2061,7 +2061,7 @@ static struct rbd_img_request *rbd_img_request_create(
>  {
>  	struct rbd_img_request *img_request;
>  
> -	img_request = kmem_cache_alloc(rbd_img_request_cache, GFP_ATOMIC);
> +	img_request = kmem_cache_alloc(rbd_img_request_cache, GFP_NOIO);
>  	if (!img_request)
>  		return NULL;
>  
>