* [PATCH] rbd: allocate img_request with GFP_NOIO instead GFP_ATOMIC
@ 2014-08-07 9:40 Ilya Dryomov
2014-08-07 11:51 ` Alex Elder
0 siblings, 1 reply; 2+ messages in thread
From: Ilya Dryomov @ 2014-08-07 9:40 UTC (permalink / raw)
To: ceph-devel
Now that rbd_img_request_create() is called from work functions, no
need to use GFP_ATOMIC.
Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
---
drivers/block/rbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 4515b128d0b4..a5ebcf28e041 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -2061,7 +2061,7 @@ static struct rbd_img_request *rbd_img_request_create(
{
struct rbd_img_request *img_request;
- img_request = kmem_cache_alloc(rbd_img_request_cache, GFP_ATOMIC);
+ img_request = kmem_cache_alloc(rbd_img_request_cache, GFP_NOIO);
if (!img_request)
return NULL;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rbd: allocate img_request with GFP_NOIO instead GFP_ATOMIC
2014-08-07 9:40 [PATCH] rbd: allocate img_request with GFP_NOIO instead GFP_ATOMIC Ilya Dryomov
@ 2014-08-07 11:51 ` Alex Elder
0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2014-08-07 11:51 UTC (permalink / raw)
To: Ilya Dryomov, ceph-devel
On 08/07/2014 04:40 AM, Ilya Dryomov wrote:
> Now that rbd_img_request_create() is called from work functions, no
> need to use GFP_ATOMIC.
>
> Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
Looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 4515b128d0b4..a5ebcf28e041 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -2061,7 +2061,7 @@ static struct rbd_img_request *rbd_img_request_create(
> {
> struct rbd_img_request *img_request;
>
> - img_request = kmem_cache_alloc(rbd_img_request_cache, GFP_ATOMIC);
> + img_request = kmem_cache_alloc(rbd_img_request_cache, GFP_NOIO);
> if (!img_request)
> return NULL;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-07 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-07 9:40 [PATCH] rbd: allocate img_request with GFP_NOIO instead GFP_ATOMIC Ilya Dryomov
2014-08-07 11:51 ` Alex Elder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.