From: Hannes Reinecke <hare@suse.de>
To: Nick Krause <xerofoiify@gmail.com>,
Matthew Wilcox <matthew@wil.cx>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
"open list:LSILOGIC/SYMBIOS/..." <linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: Check if WSR already defined
Date: Thu, 07 Aug 2014 15:07:23 +0200 [thread overview]
Message-ID: <53E37A0B.1060105@suse.de> (raw)
In-Reply-To: <1407389918-10463-1-git-send-email-xerofoiify@gmail.com>
On 08/07/2014 07:38 AM, Nick Krause wrote:
> On xtensa arch there is this warning
>
> drivers/scsi/sym53c8xx_2/sym_defs.h:109:0: warning: "WSR" redefined [enabled by default]
> arch/xtensa/include/asm/processor.h:188:0: note: this is the location of the previous definition
>
> I can remove WSR since it is not being used but more documentation purpose, so
> undefining is enough.
>
> Signed-off-by: Nick Krause <xerofoify@gmail.com>
> ---
> drivers/scsi/sym53c8xx_2/sym_defs.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/sym53c8xx_2/sym_defs.h b/drivers/scsi/sym53c8xx_2/sym_defs.h
> index defccc4..68334a5 100644
> --- a/drivers/scsi/sym53c8xx_2/sym_defs.h
> +++ b/drivers/scsi/sym53c8xx_2/sym_defs.h
> @@ -91,6 +91,10 @@ struct sym_chip {
> #define FE_CACHE0_SET (FE_CACHE_SET & ~FE_ERL)
> };
>
> +#ifdef WSR
> +#undef WSR
> +#endif
> +
> /*
> * SYM53C8XX IO register data structure.
> */
>
Ouch.
Certainly not. Who knows for which odd function the 'WSR' definition
is used.
Better to redefine WSR in sym_defs.h.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Nick Krause <xerofoiify@gmail.com>,
Matthew Wilcox <matthew@wil.cx>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
"open list:LSILOGIC/SYMBIOS/..." <linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: Check if WSR already defined
Date: Thu, 07 Aug 2014 15:07:23 +0200 [thread overview]
Message-ID: <53E37A0B.1060105@suse.de> (raw)
In-Reply-To: <1407389918-10463-1-git-send-email-xerofoiify@gmail.com>
On 08/07/2014 07:38 AM, Nick Krause wrote:
> On xtensa arch there is this warning
>
> drivers/scsi/sym53c8xx_2/sym_defs.h:109:0: warning: "WSR" redefined [enabled by default]
> arch/xtensa/include/asm/processor.h:188:0: note: this is the location of the previous definition
>
> I can remove WSR since it is not being used but more documentation purpose, so
> undefining is enough.
>
> Signed-off-by: Nick Krause <xerofoify@gmail.com>
> ---
> drivers/scsi/sym53c8xx_2/sym_defs.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/sym53c8xx_2/sym_defs.h b/drivers/scsi/sym53c8xx_2/sym_defs.h
> index defccc4..68334a5 100644
> --- a/drivers/scsi/sym53c8xx_2/sym_defs.h
> +++ b/drivers/scsi/sym53c8xx_2/sym_defs.h
> @@ -91,6 +91,10 @@ struct sym_chip {
> #define FE_CACHE0_SET (FE_CACHE_SET & ~FE_ERL)
> };
>
> +#ifdef WSR
> +#undef WSR
> +#endif
> +
> /*
> * SYM53C8XX IO register data structure.
> */
>
Ouch.
Certainly not. Who knows for which odd function the 'WSR' definition
is used.
Better to redefine WSR in sym_defs.h.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2014-08-07 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 5:38 [PATCH] scsi: Check if WSR already defined Nick Krause
2014-08-07 5:38 ` Nick Krause
2014-08-07 13:07 ` Hannes Reinecke [this message]
2014-08-07 13:07 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E37A0B.1060105@suse.de \
--to=hare@suse.de \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=xerofoiify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.