* [PATCH wpan-next] 6lowpan_rtnl: fix correct return of errno value @ 2014-08-08 6:24 Alexander Aring 2014-08-08 6:28 ` Alexander Aring 0 siblings, 1 reply; 5+ messages in thread From: Alexander Aring @ 2014-08-08 6:24 UTC (permalink / raw) To: linux-wpan; +Cc: Alexander Aring Signed-off-by: Alexander Aring <alex.aring@gmail.com> --- net/ieee802154/6lowpan_rtnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c index 0acd273..b6ec3b1 100644 --- a/net/ieee802154/6lowpan_rtnl.c +++ b/net/ieee802154/6lowpan_rtnl.c @@ -238,7 +238,7 @@ lowpan_alloc_frag(struct sk_buff *skb, int size, return ERR_PTR(-rc); } } else { - frag = ERR_PTR(ENOMEM); + frag = ERR_PTR(-ENOMEM); } return frag; -- 2.0.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH wpan-next] 6lowpan_rtnl: fix correct return of errno value 2014-08-08 6:24 [PATCH wpan-next] 6lowpan_rtnl: fix correct return of errno value Alexander Aring @ 2014-08-08 6:28 ` Alexander Aring 2014-08-08 6:37 ` Varka Bhadram 0 siblings, 1 reply; 5+ messages in thread From: Alexander Aring @ 2014-08-08 6:28 UTC (permalink / raw) To: linux-wpan On Fri, Aug 08, 2014 at 08:24:39AM +0200, Alexander Aring wrote: > Signed-off-by: Alexander Aring <alex.aring@gmail.com> > --- > net/ieee802154/6lowpan_rtnl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c > index 0acd273..b6ec3b1 100644 > --- a/net/ieee802154/6lowpan_rtnl.c > +++ b/net/ieee802154/6lowpan_rtnl.c > @@ -238,7 +238,7 @@ lowpan_alloc_frag(struct sk_buff *skb, int size, > return ERR_PTR(-rc); > } > } else { > - frag = ERR_PTR(ENOMEM); > + frag = ERR_PTR(-ENOMEM); > } > > return frag; > -- > 2.0.3 > Sorry, I will also add a "ieee802154: " to beginning of this commit msg. - Alex ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH wpan-next] 6lowpan_rtnl: fix correct return of errno value 2014-08-08 6:28 ` Alexander Aring @ 2014-08-08 6:37 ` Varka Bhadram 2014-08-08 6:48 ` Alexander Aring 0 siblings, 1 reply; 5+ messages in thread From: Varka Bhadram @ 2014-08-08 6:37 UTC (permalink / raw) To: Alexander Aring, linux-wpan On 08/08/2014 11:58 AM, Alexander Aring wrote: > On Fri, Aug 08, 2014 at 08:24:39AM +0200, Alexander Aring wrote: >> Signed-off-by: Alexander Aring <alex.aring@gmail.com> >> --- >> net/ieee802154/6lowpan_rtnl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c >> index 0acd273..b6ec3b1 100644 >> --- a/net/ieee802154/6lowpan_rtnl.c >> +++ b/net/ieee802154/6lowpan_rtnl.c >> @@ -238,7 +238,7 @@ lowpan_alloc_frag(struct sk_buff *skb, int size, >> return ERR_PTR(-rc); >> } >> } else { >> - frag = ERR_PTR(ENOMEM); >> + frag = ERR_PTR(-ENOMEM); >> } >> >> return frag; >> -- >> 2.0.3 >> > Sorry, I will also add a "ieee802154: " to beginning of this commit msg. > Also some description about patch..? -- Regards, Varka Bhadram. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH wpan-next] 6lowpan_rtnl: fix correct return of errno value 2014-08-08 6:37 ` Varka Bhadram @ 2014-08-08 6:48 ` Alexander Aring 2014-08-08 6:50 ` Varka Bhadram 0 siblings, 1 reply; 5+ messages in thread From: Alexander Aring @ 2014-08-08 6:48 UTC (permalink / raw) To: Varka Bhadram; +Cc: linux-wpan On Fri, Aug 08, 2014 at 12:07:02PM +0530, Varka Bhadram wrote: > On 08/08/2014 11:58 AM, Alexander Aring wrote: > >On Fri, Aug 08, 2014 at 08:24:39AM +0200, Alexander Aring wrote: > >>Signed-off-by: Alexander Aring <alex.aring@gmail.com> > >>--- > >> net/ieee802154/6lowpan_rtnl.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c > >>index 0acd273..b6ec3b1 100644 > >>--- a/net/ieee802154/6lowpan_rtnl.c > >>+++ b/net/ieee802154/6lowpan_rtnl.c > >>@@ -238,7 +238,7 @@ lowpan_alloc_frag(struct sk_buff *skb, int size, > >> return ERR_PTR(-rc); > >> } > >> } else { > >>- frag = ERR_PTR(ENOMEM); > >>+ frag = ERR_PTR(-ENOMEM); > >> } > >> return frag; > >>-- > >>2.0.3 > >> > >Sorry, I will also add a "ieee802154: " to beginning of this commit msg. > > > Also some description about patch..? > No, that's enough it's only one line. What should I say about that? I could say this was introduce by commit blabla... but it doesn't matter. I talked to you about you should write something in your commit msg, but this was a whole driver and there stands "Add support for cc2520..." and nothing more, nothing about hw aack support (address filter), I mean what's the driver supports for these guys which wants to use this driver. Okay, maybe they could check the hardware flags for this. I detected it by doing some experimental things to check how we can do things better. - Alex ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH wpan-next] 6lowpan_rtnl: fix correct return of errno value 2014-08-08 6:48 ` Alexander Aring @ 2014-08-08 6:50 ` Varka Bhadram 0 siblings, 0 replies; 5+ messages in thread From: Varka Bhadram @ 2014-08-08 6:50 UTC (permalink / raw) To: Alexander Aring; +Cc: linux-wpan On 08/08/2014 12:18 PM, Alexander Aring wrote: > On Fri, Aug 08, 2014 at 12:07:02PM +0530, Varka Bhadram wrote: >> On 08/08/2014 11:58 AM, Alexander Aring wrote: >>> On Fri, Aug 08, 2014 at 08:24:39AM +0200, Alexander Aring wrote: >>>> Signed-off-by: Alexander Aring <alex.aring@gmail.com> >>>> --- >>>> net/ieee802154/6lowpan_rtnl.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c >>>> index 0acd273..b6ec3b1 100644 >>>> --- a/net/ieee802154/6lowpan_rtnl.c >>>> +++ b/net/ieee802154/6lowpan_rtnl.c >>>> @@ -238,7 +238,7 @@ lowpan_alloc_frag(struct sk_buff *skb, int size, >>>> return ERR_PTR(-rc); >>>> } >>>> } else { >>>> - frag = ERR_PTR(ENOMEM); >>>> + frag = ERR_PTR(-ENOMEM); >>>> } >>>> return frag; >>>> -- >>>> 2.0.3 >>>> >>> Sorry, I will also add a "ieee802154: " to beginning of this commit msg. >>> >> Also some description about patch..? >> > No, that's enough it's only one line. What should I say about that? I > could say this was introduce by commit blabla... but it doesn't matter. > > I talked to you about you should write something in your commit msg, but > this was a whole driver and there stands "Add support for cc2520..." and > nothing more, nothing about hw aack support (address filter), I mean > what's the driver supports for these guys which wants to use this driver. > > Okay, maybe they could check the hardware flags for this. > > > I detected it by doing some experimental things to check how we can do > things better. I got your point . Thanks.. -- Regards, Varka Bhadram. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-08 6:52 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-08-08 6:24 [PATCH wpan-next] 6lowpan_rtnl: fix correct return of errno value Alexander Aring 2014-08-08 6:28 ` Alexander Aring 2014-08-08 6:37 ` Varka Bhadram 2014-08-08 6:48 ` Alexander Aring 2014-08-08 6:50 ` Varka Bhadram
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.