From: Tomasz Figa <tomasz.figa@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>,
linux-samsung-soc@vger.kernel.org,
"Hakjoo Kim" <ruppi.kim@hardkernel.com>
Cc: Tarek Dakhran <t.dakhran@samsung.com>,
Kevin Hilman <khilman@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>
Subject: Re: [RFC 4/5] ARM: dts: add pinctrl support to Exynos5410
Date: Fri, 08 Aug 2014 15:29:30 +0200 [thread overview]
Message-ID: <53E4D0BA.7050106@gmail.com> (raw)
In-Reply-To: <1406549892-5558-5-git-send-email-afaerber@suse.de>
Hi,
Please see my comment inline.
On 28.07.2014 14:18, Andreas Färber wrote:
> From: Hakjoo Kim <ruppi.kim@hardkernel.com>
>
> Add the required pin configuration support to Exynos5410 using pinctrl
> interface.
[snip]
> + pinctrl_0: pinctrl@13400000 {
> + compatible = "samsung,exynos5410-pinctrl";
> + reg = <0x13400000 0x1000>;
> + interrupts = <0 45 0>;
I believe you are missing the wake-up IRQ controller node here, which is
needed to handle the interrupts of EINTW (gpxN) banks.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 4/5] ARM: dts: add pinctrl support to Exynos5410
Date: Fri, 08 Aug 2014 15:29:30 +0200 [thread overview]
Message-ID: <53E4D0BA.7050106@gmail.com> (raw)
In-Reply-To: <1406549892-5558-5-git-send-email-afaerber@suse.de>
Hi,
Please see my comment inline.
On 28.07.2014 14:18, Andreas F?rber wrote:
> From: Hakjoo Kim <ruppi.kim@hardkernel.com>
>
> Add the required pin configuration support to Exynos5410 using pinctrl
> interface.
[snip]
> + pinctrl_0: pinctrl at 13400000 {
> + compatible = "samsung,exynos5410-pinctrl";
> + reg = <0x13400000 0x1000>;
> + interrupts = <0 45 0>;
I believe you are missing the wake-up IRQ controller node here, which is
needed to handle the interrupts of EINTW (gpxN) banks.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-08-08 13:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 12:18 [RFC 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
2014-07-28 12:18 ` Andreas Färber
2014-07-28 12:18 ` [PATCH 1/5] ARM: dts: exynos5410: Clean up SMDK5410 indentation Andreas Färber
2014-07-28 12:18 ` Andreas Färber
2014-07-28 12:18 ` Andreas Färber
[not found] ` <1406549892-5558-1-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2014-07-28 12:18 ` [PATCH 2/5] ARM: dts: exynos5410: Prepare ODROID-XU device tree Andreas Färber
2014-07-28 12:18 ` Andreas Färber
2014-07-28 12:18 ` Andreas Färber
2014-07-28 12:18 ` [RFC 3/5] pinctrl: exynos: add exynos5410 SoC specific data Andreas Färber
2014-07-28 12:18 ` Andreas Färber
2014-07-28 12:18 ` Andreas Färber
[not found] ` <1406549892-5558-4-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2014-08-08 12:55 ` Linus Walleij
2014-08-08 12:55 ` Linus Walleij
2014-08-08 12:55 ` Linus Walleij
2014-08-08 13:20 ` Tomasz Figa
2014-08-08 13:20 ` Tomasz Figa
2014-07-28 12:18 ` [RFC 4/5] ARM: dts: add pinctrl support to Exynos5410 Andreas Färber
2014-07-28 12:18 ` Andreas Färber
2014-07-28 12:18 ` Andreas Färber
2014-08-08 13:29 ` Tomasz Figa [this message]
2014-08-08 13:29 ` Tomasz Figa
2014-07-28 12:18 ` [RFC 5/5] ARM: dts: exynos5410: Add ODROID-XU LEDs Andreas Färber
2014-07-28 12:18 ` Andreas Färber
2014-07-28 12:18 ` Andreas Färber
2014-07-31 4:46 ` [RFC 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
2014-07-31 4:46 ` Andreas Färber
2015-03-14 19:13 ` Ben Gamari
2015-03-14 19:13 ` Ben Gamari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E4D0BA.7050106@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=afaerber@suse.de \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=ruppi.kim@hardkernel.com \
--cc=t.dakhran@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.