From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ugg_geth: Fix build error in -next
Date: Sun, 10 Aug 2014 11:42:41 -0700 [thread overview]
Message-ID: <53E7BD21.6010301@roeck-us.net> (raw)
In-Reply-To: <20140810183622.GC5134@pengutronix.de>
On 08/10/2014 11:36 AM, Uwe Kleine-König wrote:
> Hello Guenter,
>
> On Sun, Aug 10, 2014 at 09:19:14AM -0700, Guenter Roeck wrote:
>> powerpc:mpc83xx_defconfig and other builds fail with
>>
>> drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove':
>> drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error:
>> 'struct ucc_geth_private' has no member named 'info'
>> of_node_put(ugeth->info->tbi_node);
>> ^
>> drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error:
>> 'struct ucc_geth_private' has no member named 'info'
>> of_node_put(ugeth->info->phy_node);
>> ^
>>
>> Introduced by commit "net: ucc_geth: drop acquired references in probe error
>> path and remove".
>>
>> From the context, it appears that the variable is named ug_info.
>>
>> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> Only seen in -next.
> My patch was only sent just now, but it has the subject right:
>
Excellent.
> http://mid.gmane.org/1407695525-32227-1-git-send-email-u.kleine-koenig@pengutronix.de
>
The link doesn't seem to work for some reason.
> Another upside is that it contains a Fixes: header.
>
Even better. I need to start using that.
> Other than that my patch is the same. In case davem picks up yours:
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
I don't need the glory ;-). Dave, please pick Uwe's patch.
Thanks,
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Li Yang <leoli@freescale.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ugg_geth: Fix build error in -next
Date: Sun, 10 Aug 2014 11:42:41 -0700 [thread overview]
Message-ID: <53E7BD21.6010301@roeck-us.net> (raw)
In-Reply-To: <20140810183622.GC5134@pengutronix.de>
On 08/10/2014 11:36 AM, Uwe Kleine-König wrote:
> Hello Guenter,
>
> On Sun, Aug 10, 2014 at 09:19:14AM -0700, Guenter Roeck wrote:
>> powerpc:mpc83xx_defconfig and other builds fail with
>>
>> drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove':
>> drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error:
>> 'struct ucc_geth_private' has no member named 'info'
>> of_node_put(ugeth->info->tbi_node);
>> ^
>> drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error:
>> 'struct ucc_geth_private' has no member named 'info'
>> of_node_put(ugeth->info->phy_node);
>> ^
>>
>> Introduced by commit "net: ucc_geth: drop acquired references in probe error
>> path and remove".
>>
>> From the context, it appears that the variable is named ug_info.
>>
>> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> Only seen in -next.
> My patch was only sent just now, but it has the subject right:
>
Excellent.
> http://mid.gmane.org/1407695525-32227-1-git-send-email-u.kleine-koenig@pengutronix.de
>
The link doesn't seem to work for some reason.
> Another upside is that it contains a Fixes: header.
>
Even better. I need to start using that.
> Other than that my patch is the same. In case davem picks up yours:
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
I don't need the glory ;-). Dave, please pick Uwe's patch.
Thanks,
Guenter
next prev parent reply other threads:[~2014-08-10 18:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-10 16:19 [PATCH] net: ugg_geth: Fix build error in -next Guenter Roeck
2014-08-10 16:19 ` Guenter Roeck
2014-08-10 16:19 ` Guenter Roeck
2014-08-10 17:46 ` Guenter Roeck
2014-08-10 17:46 ` Guenter Roeck
2014-08-10 18:36 ` Uwe Kleine-König
2014-08-10 18:36 ` Uwe Kleine-König
2014-08-10 18:42 ` Guenter Roeck [this message]
2014-08-10 18:42 ` Guenter Roeck
2014-08-11 5:35 ` Uwe Kleine-König
2014-08-11 5:35 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E7BD21.6010301@roeck-us.net \
--to=linux@roeck-us.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.