From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: edma: Fix configuration parsing for SoCs with multiple eDMA3 CC
Date: Mon, 11 Aug 2014 10:58:50 +0300 [thread overview]
Message-ID: <53E877BA.6040705@ti.com> (raw)
In-Reply-To: <20140805163229.GZ8181@intel.com>
On 08/05/2014 07:32 PM, Vinod Koul wrote:
> On Mon, Aug 04, 2014 at 03:26:56PM +0300, Peter Ujfalusi wrote:
>> The edma_setup_from_hw() should know about the CC number when parsing the
>> CCCFG register - when it reads the register to be precise. The base
>> addresses for CCs stored in an array and we need to provide the correct id
>> to edma_read() in order to read the correct register.
>
> Just an othognal question:
>
> I still see lot of code for edma in arm/. What is the plan to re/move that
> to dma/
Yes, there's still a big split. The code under arch/arm/common/ provides still
the 'legacy' edma API. This is still used by audio
sound/soc/davinci/davinci-pcm for older daVinci devices (AM335x. AM43xx uses
the edma-pcm).
And it is not that simple to deprecate davinci-pcm: it can use so called
ping-pong mode for audio data transfer. This mode is not possible via
dmaengine AFAIK.
I'm going to check if edma-pcm would work fine instead of the ping-pong mode.
If it does I can remove davinci-pcm and we can start cleaning up the edma code.
--
P?ter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: <nsekhar@ti.com>, <linux@arm.linux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<davinci-linux-open-source@linux.davincidsp.com>
Subject: Re: [PATCH] ARM: edma: Fix configuration parsing for SoCs with multiple eDMA3 CC
Date: Mon, 11 Aug 2014 10:58:50 +0300 [thread overview]
Message-ID: <53E877BA.6040705@ti.com> (raw)
In-Reply-To: <20140805163229.GZ8181@intel.com>
On 08/05/2014 07:32 PM, Vinod Koul wrote:
> On Mon, Aug 04, 2014 at 03:26:56PM +0300, Peter Ujfalusi wrote:
>> The edma_setup_from_hw() should know about the CC number when parsing the
>> CCCFG register - when it reads the register to be precise. The base
>> addresses for CCs stored in an array and we need to provide the correct id
>> to edma_read() in order to read the correct register.
>
> Just an othognal question:
>
> I still see lot of code for edma in arm/. What is the plan to re/move that
> to dma/
Yes, there's still a big split. The code under arch/arm/common/ provides still
the 'legacy' edma API. This is still used by audio
sound/soc/davinci/davinci-pcm for older daVinci devices (AM335x. AM43xx uses
the edma-pcm).
And it is not that simple to deprecate davinci-pcm: it can use so called
ping-pong mode for audio data transfer. This mode is not possible via
dmaengine AFAIK.
I'm going to check if edma-pcm would work fine instead of the ping-pong mode.
If it does I can remove davinci-pcm and we can start cleaning up the edma code.
--
Péter
next prev parent reply other threads:[~2014-08-11 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 12:26 [PATCH] ARM: edma: Fix configuration parsing for SoCs with multiple eDMA3 CC Peter Ujfalusi
2014-08-04 12:26 ` Peter Ujfalusi
2014-08-05 16:32 ` Vinod Koul
2014-08-05 16:32 ` Vinod Koul
2014-08-11 7:58 ` Peter Ujfalusi [this message]
2014-08-11 7:58 ` Peter Ujfalusi
2014-08-26 9:20 ` Sekhar Nori
2014-08-26 9:20 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E877BA.6040705@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.