All of lore.kernel.org
 help / color / mirror / Atom feed
From: elfring@users.sourceforge.net (SF Markus Elfring)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH] scripts/coccinelle/free/ifnullfree.cocci: simplify and extend to of_node_put
Date: Mon, 11 Aug 2014 15:00:52 +0200	[thread overview]
Message-ID: <53E8BE84.3080505@users.sourceforge.net> (raw)
In-Reply-To: <1407752653-16883-1-git-send-email-Julia.Lawall@lip6.fr>

>  @r depends on context || report || org @
> @@ -37,7 +35,8 @@ position p;
>  @@
>  
>  * if (E)
> -*	\(kfree at p\|debugfs_remove at p\|debugfs_remove_recursive at p\|usb_free_urb\)(E);
> +*  \(kfree at p\|debugfs_remove at p\|debugfs_remove_recursive at p\|usb_free_urb at p\|
> +*    of_node_put at p\)(E);

Why do you want to limit this semantic patch pattern to such a small list of
function names?

Would you like to consider also the hundreds of other functions which perform
input parameter validation?
Are you interested to make the checked list more complete with further
(eventually automatic?) extensions?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: cocci@systeme.lip6.fr
Subject: Re: [PATCH] scripts/coccinelle/free/ifnullfree.cocci: simplify and extend to of_node_put
Date: Mon, 11 Aug 2014 13:00:52 +0000	[thread overview]
Message-ID: <53E8BE84.3080505@users.sourceforge.net> (raw)
In-Reply-To: <1407752653-16883-1-git-send-email-Julia.Lawall@lip6.fr>

>  @r depends on context || report || org @
> @@ -37,7 +35,8 @@ position p;
>  @@
>  
>  * if (E)
> -*	\(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb\)(E);
> +*  \(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb@p\|
> +*    of_node_put@p\)(E);

Why do you want to limit this semantic patch pattern to such a small list of
function names?

Would you like to consider also the hundreds of other functions which perform
input parameter validation?
Are you interested to make the checked list more complete with further
(eventually automatic?) extensions?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Coccinelle <cocci@systeme.lip6.fr>,
	kernel-janitors@vger.kernel.org,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Michal Marek <mmarek@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/coccinelle/free/ifnullfree.cocci: simplify and extend to of_node_put
Date: Mon, 11 Aug 2014 15:00:52 +0200	[thread overview]
Message-ID: <53E8BE84.3080505@users.sourceforge.net> (raw)
In-Reply-To: <1407752653-16883-1-git-send-email-Julia.Lawall@lip6.fr>

>  @r depends on context || report || org @
> @@ -37,7 +35,8 @@ position p;
>  @@
>  
>  * if (E)
> -*	\(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb\)(E);
> +*  \(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb@p\|
> +*    of_node_put@p\)(E);

Why do you want to limit this semantic patch pattern to such a small list of
function names?

Would you like to consider also the hundreds of other functions which perform
input parameter validation?
Are you interested to make the checked list more complete with further
(eventually automatic?) extensions?

Regards,
Markus

  reply	other threads:[~2014-08-11 13:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 10:24 [Cocci] [PATCH] scripts/coccinelle/free/ifnullfree.cocci: simplify and extend to of_node_put Julia Lawall
2014-08-11 10:24 ` Julia Lawall
2014-08-11 10:24 ` Julia Lawall
2014-08-11 13:00 ` SF Markus Elfring [this message]
2014-08-11 13:00   ` SF Markus Elfring
2014-08-11 13:00   ` SF Markus Elfring
2014-08-11 13:05   ` [Cocci] " Julia Lawall
2014-08-11 13:05     ` Julia Lawall
2014-08-11 13:05     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E8BE84.3080505@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.