All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] irqchip: gic: Allow gic_arch_extn hooks to call into scheduler
Date: Tue, 12 Aug 2014 15:37:00 -0700	[thread overview]
Message-ID: <53EA970C.9070003@codeaurora.org> (raw)
In-Reply-To: <alpine.LFD.2.11.1408052222350.6061@knanqh.ubzr>

On 08/05/14 19:34, Nicolas Pitre wrote:
>
>> It allows us to synchronize with another CPU that may be inside
>> gic_raise_softirq(). If the other CPU was in that function then this CPU
>> would wait until it was done sending the IPI to continue along and
>> reroute them. If the other CPU was just about to grab the sgi lock then
>> we would guarantee that the CPU would see the new gic_cpu_map value and
>> thus any redirection is not necessary.
> OK I get it now.
>
>> I hoped that the commit text explained this.
> I'm possibly not bright enough to get it the first time.
>
>> Honestly it probably isn't a noticeable performance boost either way 
>> but I think this is the best we can do.
> Sure, agreed.
>
>
>

Ok, so which patch is preferred?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] irqchip: gic: Allow gic_arch_extn hooks to call into scheduler
Date: Tue, 12 Aug 2014 15:37:00 -0700	[thread overview]
Message-ID: <53EA970C.9070003@codeaurora.org> (raw)
In-Reply-To: <alpine.LFD.2.11.1408052222350.6061@knanqh.ubzr>

On 08/05/14 19:34, Nicolas Pitre wrote:
>
>> It allows us to synchronize with another CPU that may be inside
>> gic_raise_softirq(). If the other CPU was in that function then this CPU
>> would wait until it was done sending the IPI to continue along and
>> reroute them. If the other CPU was just about to grab the sgi lock then
>> we would guarantee that the CPU would see the new gic_cpu_map value and
>> thus any redirection is not necessary.
> OK I get it now.
>
>> I hoped that the commit text explained this.
> I'm possibly not bright enough to get it the first time.
>
>> Honestly it probably isn't a noticeable performance boost either way 
>> but I think this is the best we can do.
> Sure, agreed.
>
>
>

Ok, so which patch is preferred?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2014-08-12 22:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 22:33 [PATCH] irqchip: gic: Allow gic_arch_extn hooks to call into scheduler Stephen Boyd
2014-08-04 22:33 ` Stephen Boyd
2014-08-04 23:20 ` Nicolas Pitre
2014-08-04 23:20   ` Nicolas Pitre
2014-08-04 23:22   ` Stephen Boyd
2014-08-04 23:22     ` Stephen Boyd
2014-08-04 23:27   ` [PATCH v2] " Stephen Boyd
2014-08-04 23:27     ` Stephen Boyd
2014-08-05 17:48     ` Stephen Boyd
2014-08-05 17:48       ` Stephen Boyd
2014-08-05 19:50       ` Nicolas Pitre
2014-08-05 19:50         ` Nicolas Pitre
2014-08-05 21:22         ` Stephen Boyd
2014-08-05 21:22           ` Stephen Boyd
2014-08-06  2:34           ` Nicolas Pitre
2014-08-06  2:34             ` Nicolas Pitre
2014-08-12 22:37             ` Stephen Boyd [this message]
2014-08-12 22:37               ` Stephen Boyd
2014-08-13  0:39               ` Nicolas Pitre
2014-08-13  0:39                 ` Nicolas Pitre
2014-08-13  0:43                 ` Stephen Boyd
2014-08-13  0:43                   ` Stephen Boyd
2014-08-13  0:49                   ` Nicolas Pitre
2014-08-13  0:49                     ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EA970C.9070003@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.