From: tangchen <tangchen@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: santosh.shilimkar@ti.com, grygorii.strashko@ti.com,
phacht@linux.vnet.ibm.com, yinghai@kernel.org, fabf@skynet.be,
Emilian.Medve@freescale.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
Date: Wed, 13 Aug 2014 12:57:00 +0800 [thread overview]
Message-ID: <53EAF01C.3090404@cn.fujitsu.com> (raw)
In-Reply-To: <20140812150304.74a7da3f2491f3d8f8a30107@linux-foundation.org>
On 08/13/2014 06:03 AM, Andrew Morton wrote:
> On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen <tangchen@cn.fujitsu.com> wrote:
>
>> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
>> be phys_addr_t because it is used to store the return value from
>> __memblock_find_range_bottom_up().
>>
>> The bug has not been triggered because when allocating low memory near
>> the kernel end, the "int ret" won't turn out to be minus. When we started
>> to allocate memory on other nodes, and the "int ret" could be minus.
>> Then the kernel will panic.
>>
>> A simple way to reproduce this: comment out the following code in numa_init(),
>>
>> memblock_set_bottom_up(false);
>>
>> and the kernel won't boot.
> Which kernel versions need this fix?
This bug has been in the kernel since v3.13-rc1.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: tangchen <tangchen@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <santosh.shilimkar@ti.com>, <grygorii.strashko@ti.com>,
<phacht@linux.vnet.ibm.com>, <yinghai@kernel.org>,
<fabf@skynet.be>, <Emilian.Medve@freescale.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node().
Date: Wed, 13 Aug 2014 12:57:00 +0800 [thread overview]
Message-ID: <53EAF01C.3090404@cn.fujitsu.com> (raw)
In-Reply-To: <20140812150304.74a7da3f2491f3d8f8a30107@linux-foundation.org>
On 08/13/2014 06:03 AM, Andrew Morton wrote:
> On Sun, 10 Aug 2014 14:12:03 +0800 Tang Chen <tangchen@cn.fujitsu.com> wrote:
>
>> In memblock_find_in_range_node(), we defeind ret as int. But it shoule
>> be phys_addr_t because it is used to store the return value from
>> __memblock_find_range_bottom_up().
>>
>> The bug has not been triggered because when allocating low memory near
>> the kernel end, the "int ret" won't turn out to be minus. When we started
>> to allocate memory on other nodes, and the "int ret" could be minus.
>> Then the kernel will panic.
>>
>> A simple way to reproduce this: comment out the following code in numa_init(),
>>
>> memblock_set_bottom_up(false);
>>
>> and the kernel won't boot.
> Which kernel versions need this fix?
This bug has been in the kernel since v3.13-rc1.
Thanks.
next prev parent reply other threads:[~2014-08-13 4:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-10 6:12 [PATCH 1/1] memblock, memhotplug: Fix wrong type in memblock_find_in_range_node() Tang Chen
2014-08-10 6:12 ` Tang Chen
2014-08-10 6:14 ` tangchen
2014-08-10 6:14 ` tangchen
2014-08-11 2:03 ` Xishi Qiu
2014-08-11 2:03 ` Xishi Qiu
2014-08-12 22:03 ` Andrew Morton
2014-08-12 22:03 ` Andrew Morton
2014-08-13 4:57 ` tangchen [this message]
2014-08-13 4:57 ` tangchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EAF01C.3090404@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=Emilian.Medve@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=phacht@linux.vnet.ibm.com \
--cc=santosh.shilimkar@ti.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.