All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-trivial] [PATCH] memory: Update obsolete comment about AddrRange field type
@ 2014-08-11  2:18 ` Fam Zheng
  0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2014-08-11  2:18 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, pbonzini

We are not 64 bit any more since

08dafab4 memory: use 128-bit integers for sizes and intermediates

but the comment is forgotten to be updated.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 memory.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/memory.c b/memory.c
index 64d7176..dbe6675 100644
--- a/memory.c
+++ b/memory.c
@@ -56,8 +56,7 @@ static void memory_init(void)
 typedef struct AddrRange AddrRange;
 
 /*
- * Note using signed integers limits us to physical addresses at most
- * 63 bits wide.  They are needed for negative offsetting in aliases
+ * Note that signed integers are needed for negative offsetting in aliases
  * (large MemoryRegion::alias_offset).
  */
 struct AddrRange {
-- 
2.0.3



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Qemu-devel] [PATCH] memory: Update obsolete comment about AddrRange field type
@ 2014-08-11  2:18 ` Fam Zheng
  0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2014-08-11  2:18 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, pbonzini

We are not 64 bit any more since

08dafab4 memory: use 128-bit integers for sizes and intermediates

but the comment is forgotten to be updated.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 memory.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/memory.c b/memory.c
index 64d7176..dbe6675 100644
--- a/memory.c
+++ b/memory.c
@@ -56,8 +56,7 @@ static void memory_init(void)
 typedef struct AddrRange AddrRange;
 
 /*
- * Note using signed integers limits us to physical addresses at most
- * 63 bits wide.  They are needed for negative offsetting in aliases
+ * Note that signed integers are needed for negative offsetting in aliases
  * (large MemoryRegion::alias_offset).
  */
 struct AddrRange {
-- 
2.0.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Qemu-trivial] [PATCH] memory: Update obsolete comment about AddrRange field type
  2014-08-11  2:18 ` [Qemu-devel] " Fam Zheng
@ 2014-08-13  6:16   ` Michael Tokarev
  -1 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2014-08-13  6:16 UTC (permalink / raw)
  To: Fam Zheng, qemu-devel; +Cc: qemu-trivial, pbonzini

Applied to -trivial, thank you!

/mjt


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [Qemu-trivial] [PATCH] memory: Update obsolete comment about AddrRange field type
@ 2014-08-13  6:16   ` Michael Tokarev
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2014-08-13  6:16 UTC (permalink / raw)
  To: Fam Zheng, qemu-devel; +Cc: qemu-trivial, pbonzini

Applied to -trivial, thank you!

/mjt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-08-13  6:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-11  2:18 [Qemu-trivial] [PATCH] memory: Update obsolete comment about AddrRange field type Fam Zheng
2014-08-11  2:18 ` [Qemu-devel] " Fam Zheng
2014-08-13  6:16 ` [Qemu-trivial] " Michael Tokarev
2014-08-13  6:16   ` [Qemu-devel] " Michael Tokarev

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.