From: Jyri Sarha <jsarha@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-fbdev@vger.kernel.org,
linux-omap@vger.kernel.org, peter.ujfalusi@ti.com,
liam.r.girdwood@linux.intel.com, tomi.valkeinen@ti.com,
detheridge@ti.com
Subject: Re: [PATCH v3 00/14] Rework OMAP4+ HDMI audio support
Date: Wed, 13 Aug 2014 15:51:54 +0300 [thread overview]
Message-ID: <53EB5F6A.9060308@ti.com> (raw)
In-Reply-To: <20140813110425.GL17528@sirena.org.uk>
On 08/13/2014 02:04 PM, Mark Brown wrote:
> On Fri, Aug 08, 2014 at 04:23:41PM +0300, Jyri Sarha wrote:
>> Question to ASoC maintainers:
>> Do feel it is Ok to put ASoC code outside sound/soc the way I do
>> in these patches (in patch 0006 particularly)?
>
> I'm not thrilled about the idea, it's going to result in breakage during
> API updates and more cross tree coordination needs.
>
I guess then the least bad alternative would be cutting the cpu-dai
driver away from drivers/video/fbdev/omap2/dss/hdmi_audio.c and placing
it under sound/soc/omap and registering it from hdmi_audio.c the same
way as hdmi-audio-codec and asoc-simple-card is now registered.
There would be two devices for a single ip, but at least the ASoC side
driver would receive its resources directly from the HDMI video driver
with necessary tools to synchronize the access.
This approach would work for other HDMI audio situation too, where there
would usually (for tda998x and SiI9022 at least) be a need to register
an i2s codec driver associated with the HDMI encoder. It would probably
be possible to make a single codec driver to work with multiple HDMI
encoders if the API between the codec and endcoder drivers is designed
that in mind.
How does this sound?
Best regards,
Jyri
WARNING: multiple messages have this Message-ID (diff)
From: Jyri Sarha <jsarha@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-fbdev@vger.kernel.org,
linux-omap@vger.kernel.org, peter.ujfalusi@ti.com,
liam.r.girdwood@linux.intel.com, tomi.valkeinen@ti.com,
detheridge@ti.com
Subject: Re: [PATCH v3 00/14] Rework OMAP4+ HDMI audio support
Date: Wed, 13 Aug 2014 12:51:54 +0000 [thread overview]
Message-ID: <53EB5F6A.9060308@ti.com> (raw)
In-Reply-To: <20140813110425.GL17528@sirena.org.uk>
On 08/13/2014 02:04 PM, Mark Brown wrote:
> On Fri, Aug 08, 2014 at 04:23:41PM +0300, Jyri Sarha wrote:
>> Question to ASoC maintainers:
>> Do feel it is Ok to put ASoC code outside sound/soc the way I do
>> in these patches (in patch 0006 particularly)?
>
> I'm not thrilled about the idea, it's going to result in breakage during
> API updates and more cross tree coordination needs.
>
I guess then the least bad alternative would be cutting the cpu-dai
driver away from drivers/video/fbdev/omap2/dss/hdmi_audio.c and placing
it under sound/soc/omap and registering it from hdmi_audio.c the same
way as hdmi-audio-codec and asoc-simple-card is now registered.
There would be two devices for a single ip, but at least the ASoC side
driver would receive its resources directly from the HDMI video driver
with necessary tools to synchronize the access.
This approach would work for other HDMI audio situation too, where there
would usually (for tda998x and SiI9022 at least) be a need to register
an i2s codec driver associated with the HDMI encoder. It would probably
be possible to make a single codec driver to work with multiple HDMI
encoders if the API between the codec and endcoder drivers is designed
that in mind.
How does this sound?
Best regards,
Jyri
next prev parent reply other threads:[~2014-08-13 12:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 13:23 [PATCH v3 00/14] Rework OMAP4+ HDMI audio support Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 01/14] ARM: OMAP2+: Remove non working OMAP HDMI audio initialization Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 02/14] OMAPDSS: hdmi.h: Add HDMI_AUDIO_LAYOUT_6CH enum value Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 03/14] OMAPDSS: hdmi_common: hdmi_compute_acr is needed for OMAP5 HDMI audio too Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 04/14] OMAPDSS: hdmi_wp: Add function for getting audio dma address Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 05/14] OMAPDSS: hdmi: Make hdmi structure public Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 06/14] OMAPDSS: hdmi_audio: Integrated ASoC DAI component driver implementation Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 07/14] OMAPDSS: Kconfig: Update OMAP4_DSS_HDMI_AUDIO option Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 08/14] OMAPDSS: hdmi4: Register HDMI audio ASoC drivers from HDMI driver Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 09/14] OMAPDSS: Kconfig: Update OMAP5_DSS_HDMI_AUDIO option Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 10/14] OMAPDSS: hdmi5: Register HDMI audio ASoC drivers from HDMI driver Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 11/14] ASoC: omap: Remove obsolete HDMI audio code and Kconfig options Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 12/14] OMAPDSS: hdmi4: Remove callbacks for an external ASoC DAI driver Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 13/14] OMAPDSS: hdmi5: " Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-08 13:23 ` [PATCH v3 14/14] OMAPDSS: Remove all references to obsolete HDMI audio callbacks Jyri Sarha
2014-08-08 13:23 ` Jyri Sarha
2014-08-13 11:04 ` [PATCH v3 00/14] Rework OMAP4+ HDMI audio support Mark Brown
2014-08-13 11:04 ` Mark Brown
2014-08-13 12:51 ` Jyri Sarha [this message]
2014-08-13 12:51 ` Jyri Sarha
2014-08-13 17:26 ` Mark Brown
2014-08-13 17:26 ` Mark Brown
2014-08-14 9:28 ` Jyri Sarha
2014-08-14 9:28 ` Jyri Sarha
2014-08-14 19:10 ` Mark Brown
2014-08-14 19:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EB5F6A.9060308@ti.com \
--to=jsarha@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=detheridge@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.