All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Guenter Roeck <linux@roeck-us.net>,
	Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: jdelvare@suse.de, rdunlap@infradead.org, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com, bp@suse.de,
	dan.carpenter@oracle.com, lm-sensors@lm-sensors.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH V2] hwmon, k10temp: Add support for F15h M60h
Date: Thu, 14 Aug 2014 20:22:31 +0000	[thread overview]
Message-ID: <53ED1A87.6000400@ladisch.de> (raw)
In-Reply-To: <20140814201730.GA501@roeck-us.net>

Guenter Roeck wrote:> On Thu, Aug 14, 2014 at 11:54:22AM -0500, Aravind Gopalakrishnan wrote:
>> This patch adds temperature monitoring support for F15h M60h processor.
>>  - Add new pci device id for the relevant processor
>>  - The functionality of REG_REPORTED_TEMPERATURE is moved to
>>    D0F0xBC_xD820_0CA4 [Reported Temperature Control]
>>    - So, use this to get CUR_TEMP value
>>    - Since we need an indirect register access, protect this with
>>      a mutex lock
>>  - Add Kconfig, Doc entries to indicate support for this processor.
>>
>> Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
>> ---
>> Changes in V2:
>>  - Prevent race with other code that may require indirect NB_SMU_REG access
>>  - Fix some minor style issues
>>
>>  Documentation/hwmon/k10temp   |  2 +-
>>  arch/x86/include/asm/amd_nb.h |  2 ++
>>  arch/x86/kernel/amd_nb.c      | 15 +++++++++++++++
>>  drivers/hwmon/Kconfig         |  6 +++---
>>  drivers/hwmon/k10temp.c       | 22 +++++++++++++++++++---
>>  5 files changed, 40 insertions(+), 7 deletions(-)
>>
> [ ... ]
>
>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
>> index 02d3d85..0234a08 100644
>> --- a/drivers/hwmon/Kconfig
>> +++ b/drivers/hwmon/Kconfig
>> @@ -275,13 +275,13 @@ config SENSORS_K8TEMP
>>
>>  config SENSORS_K10TEMP
>>  	tristate "AMD Family 10h+ temperature sensor"
>> -	depends on X86 && PCI
>> +	depends on X86 && PCI && AMD_NB
>
> Is the added dependency acceptable ?

Yes, it is automatically set from CPU_SUP_AMD.


Regards,
Clemens

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Clemens Ladisch <clemens@ladisch.de>
To: Guenter Roeck <linux@roeck-us.net>,
	Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: jdelvare@suse.de, rdunlap@infradead.org, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com, bp@suse.de,
	dan.carpenter@oracle.com, lm-sensors@lm-sensors.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] hwmon, k10temp: Add support for F15h M60h
Date: Thu, 14 Aug 2014 22:22:31 +0200	[thread overview]
Message-ID: <53ED1A87.6000400@ladisch.de> (raw)
In-Reply-To: <20140814201730.GA501@roeck-us.net>

Guenter Roeck wrote:> On Thu, Aug 14, 2014 at 11:54:22AM -0500, Aravind Gopalakrishnan wrote:
>> This patch adds temperature monitoring support for F15h M60h processor.
>>  - Add new pci device id for the relevant processor
>>  - The functionality of REG_REPORTED_TEMPERATURE is moved to
>>    D0F0xBC_xD820_0CA4 [Reported Temperature Control]
>>    - So, use this to get CUR_TEMP value
>>    - Since we need an indirect register access, protect this with
>>      a mutex lock
>>  - Add Kconfig, Doc entries to indicate support for this processor.
>>
>> Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
>> ---
>> Changes in V2:
>>  - Prevent race with other code that may require indirect NB_SMU_REG access
>>  - Fix some minor style issues
>>
>>  Documentation/hwmon/k10temp   |  2 +-
>>  arch/x86/include/asm/amd_nb.h |  2 ++
>>  arch/x86/kernel/amd_nb.c      | 15 +++++++++++++++
>>  drivers/hwmon/Kconfig         |  6 +++---
>>  drivers/hwmon/k10temp.c       | 22 +++++++++++++++++++---
>>  5 files changed, 40 insertions(+), 7 deletions(-)
>>
> [ ... ]
>
>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
>> index 02d3d85..0234a08 100644
>> --- a/drivers/hwmon/Kconfig
>> +++ b/drivers/hwmon/Kconfig
>> @@ -275,13 +275,13 @@ config SENSORS_K8TEMP
>>
>>  config SENSORS_K10TEMP
>>  	tristate "AMD Family 10h+ temperature sensor"
>> -	depends on X86 && PCI
>> +	depends on X86 && PCI && AMD_NB
>
> Is the added dependency acceptable ?

Yes, it is automatically set from CPU_SUP_AMD.


Regards,
Clemens

  reply	other threads:[~2014-08-14 20:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 16:54 [lm-sensors] [PATCH V2] hwmon, k10temp: Add support for F15h M60h Aravind Gopalakrishnan
2014-08-14 16:54 ` Aravind Gopalakrishnan
2014-08-14 17:32 ` [lm-sensors] " Clemens Ladisch
2014-08-14 17:32   ` Clemens Ladisch
2014-08-14 20:17 ` [lm-sensors] " Guenter Roeck
2014-08-14 20:17   ` Guenter Roeck
2014-08-14 20:22   ` Clemens Ladisch [this message]
2014-08-14 20:22     ` Clemens Ladisch
2014-08-14 21:08     ` [lm-sensors] " Borislav Petkov
2014-08-14 21:08       ` Borislav Petkov
2014-08-14 21:57       ` [lm-sensors] " Aravind Gopalakrishnan
2014-08-14 21:57         ` Aravind Gopalakrishnan
2014-08-14 22:05         ` [lm-sensors] " Borislav Petkov
2014-08-14 22:05           ` Borislav Petkov
2014-08-14 22:20           ` [lm-sensors] " Aravind Gopalakrishnan
2014-08-14 22:20             ` Aravind Gopalakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53ED1A87.6000400@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=aravind.gopalakrishnan@amd.com \
    --cc=bp@suse.de \
    --cc=dan.carpenter@oracle.com \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mingo@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.