From: dinguyen@opensource.altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 3/3] ARM: dts: socfpga: memreserve first 4KB for SMP code
Date: Fri, 15 Aug 2014 08:43:23 -0500 [thread overview]
Message-ID: <53EE0E7B.4010208@opensource.altera.com> (raw)
In-Reply-To: <20140815112758.GE15621@leverpostej>
Hi Mark,
On 8/15/14, 6:27 AM, Mark Rutland wrote:
> Hi Dinh,
>
> On Thu, Aug 14, 2014 at 10:13:34PM +0100, dinguyen at opensource.altera.com wrote:
>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> The SOCFPGA's SMP code uses 0x0 for as the location for the trampoline to
>> bring secondary cores online. This patch adds a /memreserve/ section to
>> reserve the first 4K for the SMP trampoline code.
>
> I'm slightly confused.
>
> Sorry to split hairs here, but I think the comment is subtly wrong.
>
> The trampoline code seems to be placed in this location by Linux, so
> it's not that we're protecting the trampoline code, but rather we're
> preserving the location for future use.
Yes, you're correct. Preserving this location for possible copying of
the trampoline code for SMP usage is more of a correct statement.
>
> I take it that the reset address isn't configurable?
No, I don't believe it is on this platform.
Thanks for the review. I will spin a V3 with an updated commit message.
Dinh
WARNING: multiple messages have this Message-ID (diff)
From: Dinh Nguyen <dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: "dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
<galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org"
<atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
"tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org"
<tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
"vbridger-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org"
<vbridger-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
Subject: Re: [PATCHv2 3/3] ARM: dts: socfpga: memreserve first 4KB for SMP code
Date: Fri, 15 Aug 2014 08:43:23 -0500 [thread overview]
Message-ID: <53EE0E7B.4010208@opensource.altera.com> (raw)
In-Reply-To: <20140815112758.GE15621@leverpostej>
Hi Mark,
On 8/15/14, 6:27 AM, Mark Rutland wrote:
> Hi Dinh,
>
> On Thu, Aug 14, 2014 at 10:13:34PM +0100, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote:
>> From: Dinh Nguyen <dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
>>
>> The SOCFPGA's SMP code uses 0x0 for as the location for the trampoline to
>> bring secondary cores online. This patch adds a /memreserve/ section to
>> reserve the first 4K for the SMP trampoline code.
>
> I'm slightly confused.
>
> Sorry to split hairs here, but I think the comment is subtly wrong.
>
> The trampoline code seems to be placed in this location by Linux, so
> it's not that we're protecting the trampoline code, but rather we're
> preserving the location for future use.
Yes, you're correct. Preserving this location for possible copying of
the trampoline code for SMP usage is more of a correct statement.
>
> I take it that the reset address isn't configurable?
No, I don't believe it is on this platform.
Thanks for the review. I will spin a V3 with an updated commit message.
Dinh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-08-15 13:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 21:13 [PATCHv2 0/3] ARM: dts: socfpga: updates for SOCFPGA dinguyen at opensource.altera.com
2014-08-14 21:13 ` dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-08-14 21:13 ` [PATCHv2 1/3] ARM: dts: socfpga: remove extra alias in the ArriaV devkit dinguyen at opensource.altera.com
2014-08-14 21:13 ` dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-08-14 21:13 ` [PATCHv2 2/3] ARM: dts: socfpga: Add SD card detect dinguyen at opensource.altera.com
2014-08-14 21:13 ` dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-08-14 21:13 ` [PATCHv2 3/3] ARM: dts: socfpga: memreserve first 4KB for SMP code dinguyen at opensource.altera.com
2014-08-14 21:13 ` dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-08-15 11:27 ` Mark Rutland
2014-08-15 11:27 ` Mark Rutland
2014-08-15 13:43 ` Dinh Nguyen [this message]
2014-08-15 13:43 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EE0E7B.4010208@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.