From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: extra logging for core-restart state change logic.
Date: Fri, 15 Aug 2014 07:05:40 -0700 [thread overview]
Message-ID: <53EE13B4.3030304@candelatech.com> (raw)
In-Reply-To: <87egwij6x0.fsf@kamboji.qca.qualcomm.com>
On 08/15/2014 05:04 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
>
>> From: Ben Greear <greearb@candelatech.com>
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath10k/core.c
>> +++ b/drivers/net/wireless/ath/ath10k/core.c
>> @@ -700,6 +700,7 @@ static void ath10k_core_restart(struct work_struct *work)
>> switch (ar->state) {
>> case ATH10K_STATE_ON:
>> ar->state = ATH10K_STATE_RESTARTING;
>> + ath10k_warn("core-restart, going to state RESTARTING from ON\n");
>> del_timer_sync(&ar->scan.timeout);
>> ath10k_reset_scan((unsigned long)ar);
>> ieee80211_restart_hw(ar->hw);
>> @@ -713,10 +714,11 @@ static void ath10k_core_restart(struct work_struct *work)
>> /* hw restart might be requested from multiple places */
>> break;
>> case ATH10K_STATE_RESTARTED:
>> - ar->state = ATH10K_STATE_WEDGED;
>> /* fall through */
>> case ATH10K_STATE_WEDGED:
>> - ath10k_warn("device is wedged, will not restart\n");
>> + ath10k_warn("device is wedged, will not restart (state %d)\n",
>> + ar->state);
>> + ar->state = ATH10K_STATE_WEDGED;
>> break;
>> }
>
> I think state prints should be debug messages, not part of error
> messages. For example, we could add new debug level ATH10K_DBG_CORE or
> something like that.
I'll respin the patch accordingly when I get a chance.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: extra logging for core-restart state change logic.
Date: Fri, 15 Aug 2014 07:05:40 -0700 [thread overview]
Message-ID: <53EE13B4.3030304@candelatech.com> (raw)
In-Reply-To: <87egwij6x0.fsf@kamboji.qca.qualcomm.com>
On 08/15/2014 05:04 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
>
>> From: Ben Greear <greearb@candelatech.com>
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath10k/core.c
>> +++ b/drivers/net/wireless/ath/ath10k/core.c
>> @@ -700,6 +700,7 @@ static void ath10k_core_restart(struct work_struct *work)
>> switch (ar->state) {
>> case ATH10K_STATE_ON:
>> ar->state = ATH10K_STATE_RESTARTING;
>> + ath10k_warn("core-restart, going to state RESTARTING from ON\n");
>> del_timer_sync(&ar->scan.timeout);
>> ath10k_reset_scan((unsigned long)ar);
>> ieee80211_restart_hw(ar->hw);
>> @@ -713,10 +714,11 @@ static void ath10k_core_restart(struct work_struct *work)
>> /* hw restart might be requested from multiple places */
>> break;
>> case ATH10K_STATE_RESTARTED:
>> - ar->state = ATH10K_STATE_WEDGED;
>> /* fall through */
>> case ATH10K_STATE_WEDGED:
>> - ath10k_warn("device is wedged, will not restart\n");
>> + ath10k_warn("device is wedged, will not restart (state %d)\n",
>> + ar->state);
>> + ar->state = ATH10K_STATE_WEDGED;
>> break;
>> }
>
> I think state prints should be debug messages, not part of error
> messages. For example, we could add new debug level ATH10K_DBG_CORE or
> something like that.
I'll respin the patch accordingly when I get a chance.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-08-15 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 20:54 [PATCH] ath10k: extra logging for core-restart state change logic greearb
2014-08-05 20:54 ` greearb
2014-08-15 12:04 ` Kalle Valo
2014-08-15 12:04 ` Kalle Valo
2014-08-15 14:05 ` Ben Greear [this message]
2014-08-15 14:05 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EE13B4.3030304@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.