From: Guenter Roeck <linux@roeck-us.net>
To: Phil Pokorny <ppokorny@penguincomputing.com>,
Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: "clemens@ladisch.de" <clemens@ladisch.de>,
"jdelvare@suse.de" <jdelvare@suse.de>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"bp@suse.de" <bp@suse.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH V3] hwmon, k10temp: Add support for F15h M60h
Date: Fri, 15 Aug 2014 15:39:24 +0000 [thread overview]
Message-ID: <53EE29AC.6050709@roeck-us.net> (raw)
In-Reply-To: <CAAek22FpQRhDqjSQjOL_UfoJ51hHqbxYZu2AGTA54LRM9sFn2g@mail.gmail.com>
On 08/15/2014 08:18 AM, Phil Pokorny wrote:
>
> On 08/14/2014 04:15 PM, Aravind Gopalakrishnan wrote:
>
> This patch adds temperature monitoring support for F15h M60h processor.
> - Add new pci device id for the relevant processor
> - The functionality of REG_REPORTED_TEMPERATURE is moved to
> D0F0xBC_xD820_0CA4 [Reported Temperature Control]
> - So, use this to get CUR_TEMP value
> - Since we need an indirect register access, protect this with
> a mutex lock
>
>
> What about making this a new driver forked from k10temp.
>
> AMD has changed how they report temperatures and the very different method of getting these temps suggests that it is no longer reasonable to add support to this driver for these new chips. Particular attention to the mutex required to protect the indirect register suggests that this would benefit from focus in its own driver now that there are multiple members of the "k15temp" family.
>
> Anyone else have thoughts?
>
Everything in that new driver except for reading the actual temperature
would be exactly the same. That doesn't make sense to me.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Phil Pokorny <ppokorny@penguincomputing.com>,
Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: "clemens@ladisch.de" <clemens@ladisch.de>,
"jdelvare@suse.de" <jdelvare@suse.de>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"bp@suse.de" <bp@suse.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH V3] hwmon, k10temp: Add support for F15h M60h
Date: Fri, 15 Aug 2014 08:39:24 -0700 [thread overview]
Message-ID: <53EE29AC.6050709@roeck-us.net> (raw)
In-Reply-To: <CAAek22FpQRhDqjSQjOL_UfoJ51hHqbxYZu2AGTA54LRM9sFn2g@mail.gmail.com>
On 08/15/2014 08:18 AM, Phil Pokorny wrote:
>
> On 08/14/2014 04:15 PM, Aravind Gopalakrishnan wrote:
>
> This patch adds temperature monitoring support for F15h M60h processor.
> - Add new pci device id for the relevant processor
> - The functionality of REG_REPORTED_TEMPERATURE is moved to
> D0F0xBC_xD820_0CA4 [Reported Temperature Control]
> - So, use this to get CUR_TEMP value
> - Since we need an indirect register access, protect this with
> a mutex lock
>
>
> What about making this a new driver forked from k10temp.
>
> AMD has changed how they report temperatures and the very different method of getting these temps suggests that it is no longer reasonable to add support to this driver for these new chips. Particular attention to the mutex required to protect the indirect register suggests that this would benefit from focus in its own driver now that there are multiple members of the "k15temp" family.
>
> Anyone else have thoughts?
>
Everything in that new driver except for reading the actual temperature
would be exactly the same. That doesn't make sense to me.
Guenter
next prev parent reply other threads:[~2014-08-15 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 23:15 [lm-sensors] [PATCH V3] hwmon, k10temp: Add support for F15h M60h Aravind Gopalakrishnan
2014-08-14 23:15 ` Aravind Gopalakrishnan
2014-08-15 6:16 ` [lm-sensors] " Borislav Petkov
2014-08-15 6:16 ` Borislav Petkov
2014-08-15 6:35 ` [lm-sensors] " Clemens Ladisch
2014-08-15 6:35 ` Clemens Ladisch
2014-08-15 10:45 ` [lm-sensors] " Guenter Roeck
2014-08-15 10:45 ` Guenter Roeck
2014-08-15 14:49 ` [lm-sensors] " Aravind Gopalakrishnan
2014-08-15 14:49 ` Aravind Gopalakrishnan
2014-08-15 15:18 ` [lm-sensors] " Phil Pokorny
2014-08-15 15:39 ` Guenter Roeck [this message]
2014-08-15 15:39 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EE29AC.6050709@roeck-us.net \
--to=linux@roeck-us.net \
--cc=aravind.gopalakrishnan@amd.com \
--cc=bp@suse.de \
--cc=clemens@ladisch.de \
--cc=jdelvare@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=ppokorny@penguincomputing.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.