All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: atull <atull@opensource.altera.com>
Cc: Jean Delvare <jdelvare@suse.de>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [lm-sensors] power supply gating with ltc2978
Date: Fri, 15 Aug 2014 21:58:39 +0000	[thread overview]
Message-ID: <53EE828F.2070101@roeck-us.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1408151623140.21645@atx-linux-37>

On 08/15/2014 02:34 PM, atull wrote:
> Hello,
>
> I am interested in adding functionality to be able to gate power supplies
> going through a ltc2978.  I see that there is a hwmon driver already
> existing (hwmon/pmbus/ltc2978.c).  I see some of the other hwmon drivers
> have MFD's.  It looks like this ltc driver would need a MFD and a
> regulator driver added.  However I don't see other pmbus hwmon drivers
> using MFD.
>
> So I am asking for recommendations and reservations on how to proceed here
> before I get too far with this.
>

I would suggest to add the regulator driver registration into the pmbus code.
I would have done this earlier myself, but there was no clear need for it
so I did not bother.

The functionality between regulator and limit/status reporting is heavily
intertwined in pmbus devices, and there is no clear functional separation
between power regulation and limit/status reporting related functionality.
Or, in other words, PMBus devices are not multi-function devices.

One of the challenges is that the values to write into the "operation" register
is device specific, so it is not possible to enable the functionality for all
PMBus chips. We'll need some device specific configuration data, such as on/off
values or maybe function callbacks into device specific code, to enable
regulator functionality.

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: atull <atull@opensource.altera.com>
Cc: Jean Delvare <jdelvare@suse.de>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>
Subject: Re: power supply gating with ltc2978
Date: Fri, 15 Aug 2014 14:58:39 -0700	[thread overview]
Message-ID: <53EE828F.2070101@roeck-us.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1408151623140.21645@atx-linux-37>

On 08/15/2014 02:34 PM, atull wrote:
> Hello,
>
> I am interested in adding functionality to be able to gate power supplies
> going through a ltc2978.  I see that there is a hwmon driver already
> existing (hwmon/pmbus/ltc2978.c).  I see some of the other hwmon drivers
> have MFD's.  It looks like this ltc driver would need a MFD and a
> regulator driver added.  However I don't see other pmbus hwmon drivers
> using MFD.
>
> So I am asking for recommendations and reservations on how to proceed here
> before I get too far with this.
>

I would suggest to add the regulator driver registration into the pmbus code.
I would have done this earlier myself, but there was no clear need for it
so I did not bother.

The functionality between regulator and limit/status reporting is heavily
intertwined in pmbus devices, and there is no clear functional separation
between power regulation and limit/status reporting related functionality.
Or, in other words, PMBus devices are not multi-function devices.

One of the challenges is that the values to write into the "operation" register
is device specific, so it is not possible to enable the functionality for all
PMBus chips. We'll need some device specific configuration data, such as on/off
values or maybe function callbacks into device specific code, to enable
regulator functionality.

Guenter


  reply	other threads:[~2014-08-15 21:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-15 21:34 [lm-sensors] power supply gating with ltc2978 atull
2014-08-15 21:34 ` atull
2014-08-15 21:58 ` Guenter Roeck [this message]
2014-08-15 21:58   ` Guenter Roeck
2014-08-16 13:20 ` [lm-sensors] " Mark Brown
2014-08-16 13:20   ` Mark Brown
2014-08-18  3:07   ` [lm-sensors] " Guenter Roeck
2014-08-18  3:07     ` Guenter Roeck
2014-08-19 14:21     ` [lm-sensors] " atull
2014-08-19 14:21       ` atull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EE828F.2070101@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=atull@opensource.altera.com \
    --cc=broonie@kernel.org \
    --cc=jdelvare@suse.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.