From: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: devicetree@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-pm@vger.kernel.org, Stephen Warren <swarren@wwwdotorg.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] of: Add of_match_machine helper
Date: Mon, 18 Aug 2014 13:10:13 +0300 [thread overview]
Message-ID: <53F1D105.1070107@nvidia.com> (raw)
In-Reply-To: <20140817152854.5406BC40ADD@trevor.secretlab.ca>
On 17/08/14 18:28, Grant Likely wrote:
> On Fri, 8 Aug 2014 02:01:53 +0300, Tuomas Tynkkynen <ttynkkynen@nvidia.com> wrote:
[...]
>> +EXPORT_SYMBOL(of_match_machine);
>
> Too wordy...
>
> return of_match_node(matches, of_allnodes);
>
> :-)
>
> It could be a static inline, but I don't think it's even worth having a
> helper. The callers could just open code the above.
>
Do you mean all the drivers should be referring to of_allnodes directly?
I see that it's indeed exported, but to me that sounds like relying too
much on an implementation detail. In fact, Documentation/devicetree/todo.txt
even seems to have a TODO entry for its removal ("Remove of_allnodes list
and iterate using list of child nodes alone").
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: ttynkkynen@nvidia.com (Tuomas Tynkkynen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] of: Add of_match_machine helper
Date: Mon, 18 Aug 2014 13:10:13 +0300 [thread overview]
Message-ID: <53F1D105.1070107@nvidia.com> (raw)
In-Reply-To: <20140817152854.5406BC40ADD@trevor.secretlab.ca>
On 17/08/14 18:28, Grant Likely wrote:
> On Fri, 8 Aug 2014 02:01:53 +0300, Tuomas Tynkkynen <ttynkkynen@nvidia.com> wrote:
[...]
>> +EXPORT_SYMBOL(of_match_machine);
>
> Too wordy...
>
> return of_match_node(matches, of_allnodes);
>
> :-)
>
> It could be a static inline, but I don't think it's even worth having a
> helper. The callers could just open code the above.
>
Do you mean all the drivers should be referring to of_allnodes directly?
I see that it's indeed exported, but to me that sounds like relying too
much on an implementation detail. In fact, Documentation/devicetree/todo.txt
even seems to have a TODO entry for its removal ("Remove of_allnodes list
and iterate using list of child nodes alone").
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
<linux-pm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH 1/3] of: Add of_match_machine helper
Date: Mon, 18 Aug 2014 13:10:13 +0300 [thread overview]
Message-ID: <53F1D105.1070107@nvidia.com> (raw)
In-Reply-To: <20140817152854.5406BC40ADD@trevor.secretlab.ca>
On 17/08/14 18:28, Grant Likely wrote:
> On Fri, 8 Aug 2014 02:01:53 +0300, Tuomas Tynkkynen <ttynkkynen@nvidia.com> wrote:
[...]
>> +EXPORT_SYMBOL(of_match_machine);
>
> Too wordy...
>
> return of_match_node(matches, of_allnodes);
>
> :-)
>
> It could be a static inline, but I don't think it's even worth having a
> helper. The callers could just open code the above.
>
Do you mean all the drivers should be referring to of_allnodes directly?
I see that it's indeed exported, but to me that sounds like relying too
much on an implementation detail. In fact, Documentation/devicetree/todo.txt
even seems to have a TODO entry for its removal ("Remove of_allnodes list
and iterate using list of child nodes alone").
--
nvpublic
next prev parent reply other threads:[~2014-08-18 10:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 23:01 [PATCH 0/3] Introduce of_match_machine() helper Tuomas Tynkkynen
2014-08-07 23:01 ` Tuomas Tynkkynen
2014-08-07 23:01 ` Tuomas Tynkkynen
2014-08-07 23:01 ` [PATCH 1/3] of: Add of_match_machine helper Tuomas Tynkkynen
2014-08-07 23:01 ` Tuomas Tynkkynen
2014-08-07 23:01 ` Tuomas Tynkkynen
[not found] ` <1407452515-2390-2-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-08 9:41 ` Thierry Reding
2014-08-08 9:41 ` Thierry Reding
2014-08-08 9:41 ` Thierry Reding
2014-08-08 13:23 ` Tuomas Tynkkynen
2014-08-08 13:23 ` Tuomas Tynkkynen
2014-08-08 13:23 ` Tuomas Tynkkynen
2014-08-08 19:01 ` Rob Herring
2014-08-08 19:01 ` Rob Herring
2014-08-17 15:31 ` Grant Likely
2014-08-17 15:31 ` Grant Likely
2014-08-17 15:28 ` Grant Likely
2014-08-17 15:28 ` Grant Likely
2014-08-17 15:28 ` Grant Likely
2014-08-18 10:10 ` Tuomas Tynkkynen [this message]
2014-08-18 10:10 ` Tuomas Tynkkynen
2014-08-18 10:10 ` Tuomas Tynkkynen
[not found] ` <1407452515-2390-1-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-07 23:01 ` [PATCH 2/3] soc/tegra: Use of_match_machine in soc_is_tegra() Tuomas Tynkkynen
2014-08-07 23:01 ` Tuomas Tynkkynen
2014-08-07 23:01 ` Tuomas Tynkkynen
[not found] ` <1407452515-2390-3-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-07 23:28 ` Stephen Warren
2014-08-07 23:28 ` Stephen Warren
2014-08-07 23:28 ` Stephen Warren
2014-08-08 9:43 ` Thierry Reding
2014-08-08 9:43 ` Thierry Reding
2014-08-07 23:01 ` [PATCH 3/3] cpuidle: big.LITTLE: Use of_match_machine Tuomas Tynkkynen
2014-08-07 23:01 ` Tuomas Tynkkynen
2014-08-07 23:01 ` Tuomas Tynkkynen
[not found] ` <1407452515-2390-4-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-08 9:45 ` Thierry Reding
2014-08-08 9:45 ` Thierry Reding
2014-08-08 9:45 ` Thierry Reding
2014-08-25 17:45 ` [PATCH 0/3] Introduce of_match_machine() helper Stephen Warren
2014-08-25 17:45 ` Stephen Warren
[not found] ` <53FB7642.1000808-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-09-19 13:12 ` Peter De Schrijver
2014-09-19 13:12 ` Peter De Schrijver
2014-09-19 13:12 ` Peter De Schrijver
2014-09-24 7:44 ` Peter De Schrijver
2014-09-24 7:44 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F1D105.1070107@nvidia.com \
--to=ttynkkynen@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.