From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] qcow2: Add runtime options for cache sizes
Date: Mon, 18 Aug 2014 22:24:16 +0200 [thread overview]
Message-ID: <53F260F0.6000805@redhat.com> (raw)
In-Reply-To: <53F25FAC.9050902@redhat.com>
On 18.08.2014 22:18, Eric Blake wrote:
> On 08/18/2014 02:00 PM, Max Reitz wrote:
>> Add options for specifying the size of the metadata caches. This can
>> either be done directly for each cache (if only one is given, the other
>> will be derived according to a default ratio) or combined for both.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> block/qcow2.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++++++-------
>> block/qcow2.h | 3 ++
>> 2 files changed, 103 insertions(+), 12 deletions(-)
> I would suspect that you need to also modify qapi/block-core.json to
> document the new QMP parameters that can be tuned when hot-plugging a
> qcow2 disk.
Oh, you're right - that structure is missing all of the corruption
detection parameters as well. I'll prepare a follow-up patch tomorrow.
Max
next prev parent reply other threads:[~2014-08-18 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 20:00 [Qemu-devel] [PATCH 0/4] qcow2: Allow runtime specification of cache sizes Max Reitz
2014-08-18 20:00 ` [Qemu-devel] [PATCH 1/4] qcow2: Constant cache size in bytes Max Reitz
2014-08-18 20:00 ` [Qemu-devel] [PATCH 2/4] qcow2: Use g_try_new0() for cache array Max Reitz
2014-08-18 20:01 ` Max Reitz
2014-08-18 20:00 ` [Qemu-devel] [PATCH 3/4] qcow2: Add runtime options for cache sizes Max Reitz
2014-08-18 20:18 ` Eric Blake
2014-08-18 20:24 ` Max Reitz [this message]
2014-08-18 20:25 ` Max Reitz
2014-08-18 20:00 ` [Qemu-devel] [PATCH 4/4] iotests: Add test for qcow2's cache options Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F260F0.6000805@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.