Re: [Qemu-devel] [PATCH 3/4] qcow2: Add runtime options for cache sizes

[Max Reitz <mreitz@redhat.com>]

On 18.08.2014 22:24, Max Reitz wrote:
> On 18.08.2014 22:18, Eric Blake wrote:
>> On 08/18/2014 02:00 PM, Max Reitz wrote:
>>> Add options for specifying the size of the metadata caches. This can
>>> either be done directly for each cache (if only one is given, the other
>>> will be derived according to a default ratio) or combined for both.
>>>
>>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>>> ---
>>>   block/qcow2.c | 112 
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++-------
>>>   block/qcow2.h |   3 ++
>>>   2 files changed, 103 insertions(+), 12 deletions(-)
>> I would suspect that you need to also modify qapi/block-core.json to
>> document the new QMP parameters that can be tuned when hot-plugging a
>> qcow2 disk.
>
> Oh, you're right - that structure is missing all of the corruption 
> detection parameters as well. I'll prepare a follow-up patch tomorrow.

Make that "on Wednesday", as I won't be around tomorrow.

Max