From: Kishon Vijay Abraham I <kishon@ti.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
grant.likely@linaro.org, devicetree@vger.kernel.org
Cc: rdunlap@infradead.org, linux-doc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5] phy: Renesas R-Car Gen2 PHY driver
Date: Tue, 19 Aug 2014 06:59:18 +0000 [thread overview]
Message-ID: <53F2F2F6.8050908@ti.com> (raw)
In-Reply-To: <53F27D23.3040002@cogentembedded.com>
On Tuesday 19 August 2014 03:54 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 07/22/2014 11:27 PM, Sergei Shtylyov wrote:
>
>> This PHY, though formally being a part of Renesas USBHS controller, contains the
>> UGCTRL2 register that controls multiplexing of the USB ports (Renesas calls them
>> channels) to the different USB controllers: channel 0 can be connected to either
>> PCI EHCI/OHCI or USBHS controllers, channel 2 can be connected to PCI EHCI/OHCI
>> or xHCI controllers.
>
>> This is a new driver for this USB PHY currently already supported under drivers/
>> usb/phy/. The reason for writing the new driver was the requirement that the
>> multiplexing of USB channels to the controller be dynamic, depending on what
>> USB drivers are loaded, rather than static as provided by the old driver. The
>> infrastructure provided by drivers/phy/phy-core.c seems to fit that purpose
>> ideally. The new driver only supports device tree probing for now.
>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
>> ---
>> The patch is against the 'next' branch of Kishon's 'linux-phy.git' repo.
>
> Kishon, may I ask what was the problem with this patch? I don't see it in
> 3.17-rc1 and you've never replied though nearly a month has passed...
It was too late to make it to 3.17.
Overall this patch looks much better. will take a closer look in a day.
Thanks
Kishon
>
> WBR, Sergei
>
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
grant.likely@linaro.org, devicetree@vger.kernel.org
Cc: rdunlap@infradead.org, linux-doc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5] phy: Renesas R-Car Gen2 PHY driver
Date: Tue, 19 Aug 2014 12:17:18 +0530 [thread overview]
Message-ID: <53F2F2F6.8050908@ti.com> (raw)
In-Reply-To: <53F27D23.3040002@cogentembedded.com>
On Tuesday 19 August 2014 03:54 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 07/22/2014 11:27 PM, Sergei Shtylyov wrote:
>
>> This PHY, though formally being a part of Renesas USBHS controller, contains the
>> UGCTRL2 register that controls multiplexing of the USB ports (Renesas calls them
>> channels) to the different USB controllers: channel 0 can be connected to either
>> PCI EHCI/OHCI or USBHS controllers, channel 2 can be connected to PCI EHCI/OHCI
>> or xHCI controllers.
>
>> This is a new driver for this USB PHY currently already supported under drivers/
>> usb/phy/. The reason for writing the new driver was the requirement that the
>> multiplexing of USB channels to the controller be dynamic, depending on what
>> USB drivers are loaded, rather than static as provided by the old driver. The
>> infrastructure provided by drivers/phy/phy-core.c seems to fit that purpose
>> ideally. The new driver only supports device tree probing for now.
>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
>> ---
>> The patch is against the 'next' branch of Kishon's 'linux-phy.git' repo.
>
> Kishon, may I ask what was the problem with this patch? I don't see it in
> 3.17-rc1 and you've never replied though nearly a month has passed...
It was too late to make it to 3.17.
Overall this patch looks much better. will take a closer look in a day.
Thanks
Kishon
>
> WBR, Sergei
>
next prev parent reply other threads:[~2014-08-19 6:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 19:27 [PATCH v5] phy: Renesas R-Car Gen2 PHY driver Sergei Shtylyov
2014-07-22 19:27 ` Sergei Shtylyov
2014-08-18 22:24 ` Sergei Shtylyov
2014-08-18 22:24 ` Sergei Shtylyov
2014-08-19 6:47 ` Kishon Vijay Abraham I [this message]
2014-08-19 6:59 ` Kishon Vijay Abraham I
2014-08-20 14:42 ` Kishon Vijay Abraham I
2014-08-20 14:54 ` Kishon Vijay Abraham I
2014-09-05 18:46 ` Sergei Shtylyov
2014-09-05 18:46 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F2F2F6.8050908@ti.com \
--to=kishon@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.