All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <namit@cs.technion.ac.il>, gleb@kernel.org
Cc: kvm@vger.kernel.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH kvm-unit-tests 1/2] x86: Use host CPU parameter for apic test
Date: Tue, 19 Aug 2014 11:51:05 +0200	[thread overview]
Message-ID: <53F31E09.1060307@redhat.com> (raw)
In-Reply-To: <1408391038-2930-1-git-send-email-namit@cs.technion.ac.il>

Il 18/08/2014 21:43, Nadav Amit ha scritto:
> Currently, the TSC deadline test never runs, since TSC deadline is disabled
> unless the host cpu parameter is used. This patch changes the apic test to use
> the qemu host cpu parameter.

Better use
> Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
> ---
>  x86/unittests.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> index 6d3e23a..f692b2b 100644
> --- a/x86/unittests.cfg
> +++ b/x86/unittests.cfg
> @@ -9,7 +9,7 @@
>  [apic]
>  file = apic.flat
>  smp = 2
> -extra_params = -cpu qemu64,+x2apic
> +extra_params = -cpu host,+x2apic
>  arch = x86_64
>  
>  [smptest]
> 

Eduardo, I think we should add tsc_deadline to QEMU instead?

Paolo

  parent reply	other threads:[~2014-08-19  9:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18 19:42 [PATCH] KVM: x86: Clear apic tsc-deadline after deadline Nadav Amit
2014-08-18 19:43 ` [PATCH kvm-unit-tests 1/2] x86: Use host CPU parameter for apic test Nadav Amit
2014-08-18 19:43   ` [PATCH kvm-unit-tests 2/2] x86: Check deadline counter is cleared after interrupt Nadav Amit
2014-08-19 10:06     ` Paolo Bonzini
2014-08-19  9:51   ` Paolo Bonzini [this message]
2014-08-19 13:18     ` [PATCH kvm-unit-tests 1/2] x86: Use host CPU parameter for apic test Eduardo Habkost
2014-08-19 13:23       ` Paolo Bonzini
2014-08-19 10:36 ` [PATCH] KVM: x86: Clear apic tsc-deadline after deadline Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F31E09.1060307@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=namit@cs.technion.ac.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.