Re: [PATCH kvm-unit-tests 1/2] x86: Use host CPU parameter for apic test

[Paolo Bonzini <pbonzini@redhat.com>]

Il 19/08/2014 15:18, Eduardo Habkost ha scritto:
> On Tue, Aug 19, 2014 at 11:51:05AM +0200, Paolo Bonzini wrote:
>> Il 18/08/2014 21:43, Nadav Amit ha scritto:
>>> Currently, the TSC deadline test never runs, since TSC deadline is disabled
>>> unless the host cpu parameter is used. This patch changes the apic test to use
>>> the qemu host cpu parameter.
>>
>> Better use
>>> Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
>>> ---
>>>  x86/unittests.cfg | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
>>> index 6d3e23a..f692b2b 100644
>>> --- a/x86/unittests.cfg
>>> +++ b/x86/unittests.cfg
>>> @@ -9,7 +9,7 @@
>>>  [apic]
>>>  file = apic.flat
>>>  smp = 2
>>> -extra_params = -cpu qemu64,+x2apic
>>> +extra_params = -cpu host,+x2apic
>>>  arch = x86_64
>>>  
>>>  [smptest]
>>>
>>
>> Eduardo, I think we should add tsc_deadline to QEMU instead?
> 
> "+tsc-deadline" is supported by QEMU since v1.1.0.

Thanks, I applied this:

diff --git a/x86/unittests.cfg b/x86/unittests.cfg
index 6d3e23a..0123944 100644
--- a/x86/unittests.cfg
+++ b/x86/unittests.cfg
@@ -9,7 +9,7 @@
 [apic]
 file = apic.flat
 smp = 2
-extra_params = -cpu qemu64,+x2apic
+extra_params = -cpu qemu64,+x2apic,+tsc-deadline
 arch = x86_64

 [smptest]

Paolo