From: Jonathan Cameron <jic23@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, monstr@monstr.eu
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: adc: xilinx: Remove .owner field for driver
Date: Tue, 19 Aug 2014 20:23:45 +0100 [thread overview]
Message-ID: <53F3A441.1040103@kernel.org> (raw)
In-Reply-To: <32522124850adfda5c6cb8a7759d0e3a63893c1e.1407931250.git.michal.simek@xilinx.com>
On 13/08/14 13:00, Michal Simek wrote:
> There is no need to init .owner field.
>
> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
> "mmc: remove .owner field for drivers using module_platform_driver"
>
> This patch removes the superflous .owner field for drivers which
> use the module_platform_driver API, as this is overriden in
> platform_driver_register anyway."
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
>
> drivers/iio/adc/xilinx-xadc-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index fd2745c62943..92541a80b041 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1322,7 +1322,6 @@ static struct platform_driver xadc_driver = {
> .remove = xadc_remove,
> .driver = {
> .name = "xadc",
> - .owner = THIS_MODULE,
> .of_match_table = xadc_of_match_table,
> },
> };
> --
> 1.8.2.3
>
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iio: adc: xilinx: Remove .owner field for driver
Date: Tue, 19 Aug 2014 20:23:45 +0100 [thread overview]
Message-ID: <53F3A441.1040103@kernel.org> (raw)
In-Reply-To: <32522124850adfda5c6cb8a7759d0e3a63893c1e.1407931250.git.michal.simek@xilinx.com>
On 13/08/14 13:00, Michal Simek wrote:
> There is no need to init .owner field.
>
> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
> "mmc: remove .owner field for drivers using module_platform_driver"
>
> This patch removes the superflous .owner field for drivers which
> use the module_platform_driver API, as this is overriden in
> platform_driver_register anyway."
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
>
> drivers/iio/adc/xilinx-xadc-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index fd2745c62943..92541a80b041 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1322,7 +1322,6 @@ static struct platform_driver xadc_driver = {
> .remove = xadc_remove,
> .driver = {
> .name = "xadc",
> - .owner = THIS_MODULE,
> .of_match_table = xadc_of_match_table,
> },
> };
> --
> 1.8.2.3
>
next prev parent reply other threads:[~2014-08-19 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 12:00 [PATCH] iio: adc: xilinx: Remove .owner field for driver Michal Simek
2014-08-13 12:00 ` Michal Simek
2014-08-19 19:23 ` Jonathan Cameron [this message]
2014-08-19 19:23 ` Jonathan Cameron
2014-08-20 7:38 ` sanjeev sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F3A441.1040103@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.