From: Julien Grall <julien.grall@linaro.org>
To: Suriyan Ramasami <suriyan.r@gmail.com>
Cc: keir@xen.org, Ian Campbell <ian.campbell@citrix.com>,
ian.jackson@eu.citrix.com, Tim Deegan <tim@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [Patch v3 1/1] Add Odroid-XU (Exynos5410)
Date: Tue, 19 Aug 2014 16:46:10 -0500 [thread overview]
Message-ID: <53F3C5A2.40902@linaro.org> (raw)
In-Reply-To: <CANoR_OBCZcSe6s8AKhYZX=dmC9+ECivGZFEMRkFreTsK0Tpvbw@mail.gmail.com>
Hello,
On 18/08/14 17:21, Suriyan Ramasami wrote:
>> I would rename S5P_PA_SYSRAM and EXYNOS5_* to something specific to exynos
>> 5250. It would make clear that new platform should use the device tree to
>> get information.
>>
> I shall rename S5P_PA_SYSRAM to EXYNOS5250_PA_SYSRAM.
> Do you also want me to rename the other ones, like EXYNOS5_MCT_*
> defines in the exynos5.h header file as well?
You are using EXYNOS5_MCT_* on both board so I don't think you have to
rename it. The best things would be using the device tree rather than an
hardcoded value.
But it's not the scope of this patch :).
> If so, do you want me to get rid of exynos5.h and dump all the defines
> in exynos5.c ?
It would be nice but not necessary for this patch.
Regards,
--
Julien Grall
prev parent reply other threads:[~2014-08-19 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 3:12 [Patch v3 1/1] Add Odroid-XU (Exynos5410) Suriyan Ramasami
2014-08-18 19:07 ` Julien Grall
2014-08-18 22:21 ` Suriyan Ramasami
2014-08-19 21:46 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F3C5A2.40902@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=suriyan.r@gmail.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.