All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: chenj <chenj@lemote.com>, <linux-mips@linux-mips.org>
Cc: <chenhc@lemote.com>, <ralf@linux-mips.org>
Subject: Re: [PATCH] mips: define _MIPS_ARCH_LOONGSON3A for Loongson3
Date: Wed, 20 Aug 2014 11:04:50 +0100	[thread overview]
Message-ID: <53F472C2.2030202@imgtec.com> (raw)
In-Reply-To: <1408504488-12319-2-git-send-email-chenj@lemote.com>

Hi,

On 20/08/14 04:14, chenj wrote:
> diff --git a/arch/mips/loongson/Platform b/arch/mips/loongson/Platform
> index 0ac20eb..5f527d1 100644
> --- a/arch/mips/loongson/Platform
> +++ b/arch/mips/loongson/Platform
> @@ -22,6 +22,9 @@ ifdef CONFIG_CPU_LOONGSON2F_WORKAROUNDS
>    endif
>  endif
>  
> +# Define _MIPS_ARCH_LOONGSON3A for Loongson3
> +cflags-$(CONFIG_CPU_LOONGSON3)  += -D_MIPS_ARCH_LOONGSON3A

Any reason not to just refer directly to CONFIG_CPU_LOONGSON3 from the
source rather than adding an intermediate definition?

Cheers
James

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: chenj <chenj@lemote.com>, linux-mips@linux-mips.org
Cc: chenhc@lemote.com, ralf@linux-mips.org
Subject: Re: [PATCH] mips: define _MIPS_ARCH_LOONGSON3A for Loongson3
Date: Wed, 20 Aug 2014 11:04:50 +0100	[thread overview]
Message-ID: <53F472C2.2030202@imgtec.com> (raw)
Message-ID: <20140820100450.SpI98MnTpOQ0hY65bOfWW_tT44O0koY00-Rw7HL4RLE@z> (raw)
In-Reply-To: <1408504488-12319-2-git-send-email-chenj@lemote.com>

Hi,

On 20/08/14 04:14, chenj wrote:
> diff --git a/arch/mips/loongson/Platform b/arch/mips/loongson/Platform
> index 0ac20eb..5f527d1 100644
> --- a/arch/mips/loongson/Platform
> +++ b/arch/mips/loongson/Platform
> @@ -22,6 +22,9 @@ ifdef CONFIG_CPU_LOONGSON2F_WORKAROUNDS
>    endif
>  endif
>  
> +# Define _MIPS_ARCH_LOONGSON3A for Loongson3
> +cflags-$(CONFIG_CPU_LOONGSON3)  += -D_MIPS_ARCH_LOONGSON3A

Any reason not to just refer directly to CONFIG_CPU_LOONGSON3 from the
source rather than adding an intermediate definition?

Cheers
James

  reply	other threads:[~2014-08-20 10:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20  3:14 [PATCH 1/2] mips: .../swab.h: fix a compiling failure chenj
2014-08-20  3:14 ` [PATCH] mips: define _MIPS_ARCH_LOONGSON3A for Loongson3 chenj
2014-08-20 10:04   ` James Hogan [this message]
2014-08-20 10:04     ` James Hogan
2014-08-20 10:53   ` Ralf Baechle
2014-08-20 11:59     ` Chen Jie
2014-08-25 12:12       ` Ralf Baechle
2014-08-25 19:35         ` Maciej W. Rozycki
2014-08-25 19:41           ` Ralf Baechle
2014-08-26  1:12             ` Chen Jie
2014-08-25 12:07 ` [PATCH 1/2] mips: .../swab.h: fix a compiling failure Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F472C2.2030202@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=chenhc@lemote.com \
    --cc=chenj@lemote.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.