From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>, Mark Brown <broonie@kernel.org>,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
Rahul Sharma <rahul.sharma@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards
Date: Wed, 20 Aug 2014 12:36:11 +0200 [thread overview]
Message-ID: <53F47A1B.2030204@collabora.co.uk> (raw)
In-Reply-To: <53F476C6.9030809@collabora.co.uk>
Hello Andreas,
On 08/20/2014 12:21 PM, Javier Martinez Canillas wrote:
> Hello Andreas,
>
> Thanks a lot for your feedback.
>
> On 08/19/2014 08:37 PM, Andreas Färber wrote:
>>> &mmc_2 {
>>> + vmmc-supply = <&tps65090_fet4>;
>>> + vqmmc-supply = <&vqmmc_sdcard>;
>>> status = "okay";
>>> num-slots = <1>;
>>> supports-highspeed;
>>
>> A convention that I picked up was to place overridden status property
>> first. Do your new properties really need to go before that?
>>
>
> OF doesn't care about the order of the child nodes but I do agree that
> consistency is a good thing so I'll change that on v2.
>
Actually I meant that I'll change this for a future re-post since I'm
completely dropping this patch from the series due Doug's explanation
about the CD line and VCCQ/VDD_IO being in the same power rail on Exynos5
SoCs.
Sorry for the noise...
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards
Date: Wed, 20 Aug 2014 12:36:11 +0200 [thread overview]
Message-ID: <53F47A1B.2030204@collabora.co.uk> (raw)
In-Reply-To: <53F476C6.9030809@collabora.co.uk>
Hello Andreas,
On 08/20/2014 12:21 PM, Javier Martinez Canillas wrote:
> Hello Andreas,
>
> Thanks a lot for your feedback.
>
> On 08/19/2014 08:37 PM, Andreas F?rber wrote:
>>> &mmc_2 {
>>> + vmmc-supply = <&tps65090_fet4>;
>>> + vqmmc-supply = <&vqmmc_sdcard>;
>>> status = "okay";
>>> num-slots = <1>;
>>> supports-highspeed;
>>
>> A convention that I picked up was to place overridden status property
>> first. Do your new properties really need to go before that?
>>
>
> OF doesn't care about the order of the child nodes but I do agree that
> consistency is a good thing so I'll change that on v2.
>
Actually I meant that I'll change this for a future re-post since I'm
completely dropping this patch from the series due Doug's explanation
about the CD line and VCCQ/VDD_IO being in the same power rail on Exynos5
SoCs.
Sorry for the noise...
Best regards,
Javier
next prev parent reply other threads:[~2014-08-20 10:36 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 15:08 [PATCH 0/6] Add max77802 support for Peach boards Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 1/6] ARM: dts: Add Peach Pit and Pi dts entry for max77802 PMIC Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 18:52 ` Andreas Färber
2014-08-19 18:52 ` Andreas Färber
2014-08-20 10:27 ` Javier Martinez Canillas
2014-08-20 10:27 ` Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 2/6] ARM: dts: add hdmi regulators for exynos5800 based peach-pi board Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-09-10 4:44 ` Doug Anderson
2014-09-10 4:44 ` Doug Anderson
2014-09-10 4:45 ` Doug Anderson
2014-09-10 4:45 ` Doug Anderson
2014-09-10 9:00 ` Javier Martinez Canillas
2014-09-10 9:00 ` Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 3/6] ARM: dts: add hdmi regulators for exynos5420 based peach-pit board Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 4/6] ARM: dts: Add thermistor dts fragment used by exynos based Peach boards Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 16:26 ` Doug Anderson
2014-08-19 16:26 ` Doug Anderson
2014-08-20 9:49 ` Javier Martinez Canillas
2014-08-20 9:49 ` Javier Martinez Canillas
2014-08-20 9:49 ` Javier Martinez Canillas
2014-08-19 18:37 ` Andreas Färber
2014-08-19 18:37 ` Andreas Färber
2014-08-20 10:21 ` Javier Martinez Canillas
2014-08-20 10:21 ` Javier Martinez Canillas
2014-08-20 10:36 ` Javier Martinez Canillas [this message]
2014-08-20 10:36 ` Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 6/6] ARM: dts: Add Peach Pit and Pi dts entry for ISL29018 sensor Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
2014-08-19 15:08 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F47A1B.2030204@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=afaerber@suse.de \
--cc=broonie@kernel.org \
--cc=ch.naveen@samsung.com \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rahul.sharma@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.