All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com,
	peterz@infradead.org, mingo@redhat.com, ak@linux.intel.com,
	tim.c.chen@linux.intel.com, akpm@linux-foundation.org,
	cl@linux.com, penberg@kernel.org, linux-mm@kvack.org,
	kirill@shutemov.name, lauraa@codeaurora.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] [v2] TAINT_PERFORMANCE
Date: Wed, 20 Aug 2014 08:02:31 -0700	[thread overview]
Message-ID: <53F4B887.7060701@sr71.net> (raw)
In-Reply-To: <20140820081158.GA3991@gmail.com>

On 08/20/2014 01:11 AM, Ingo Molnar wrote:
> In any case I don't think it's a good idea to abuse existing 
> facilities just to gain attention: you'll get the extra 
> attention, but the abuse dilutes the utility of those only 
> tangentially related facilities.

I'm happy to rip the TAINT parts out.  I was just hoping that some
tooling might pick up the taint flags today, and this could get picked
up without modification of whatever those tools are.

I was _really_ hoping the dmesg from the taint would be ugly and loud
enough to be sufficient, but it was relatively terse.

> A better option might be to declare known performance killers 
> in /proc/config_debug or so, and maybe print them once at the 
> end of the bootup, with a 'WARNING:' or 'INFO:' prefix. That 
> way tooling (benchmarks, profilers, etc.) can print them, but 
> it's also present in the syslog, just in case.

Sounds reasonable to me.  As long as we have _something_ that shows up
in dmesg, it will help.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com,
	peterz@infradead.org, mingo@redhat.com, ak@linux.intel.com,
	tim.c.chen@linux.intel.com, akpm@linux-foundation.org,
	cl@linux.com, penberg@kernel.org, linux-mm@kvack.org,
	kirill@shutemov.name, lauraa@codeaurora.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] [v2] TAINT_PERFORMANCE
Date: Wed, 20 Aug 2014 08:02:31 -0700	[thread overview]
Message-ID: <53F4B887.7060701@sr71.net> (raw)
In-Reply-To: <20140820081158.GA3991@gmail.com>

On 08/20/2014 01:11 AM, Ingo Molnar wrote:
> In any case I don't think it's a good idea to abuse existing 
> facilities just to gain attention: you'll get the extra 
> attention, but the abuse dilutes the utility of those only 
> tangentially related facilities.

I'm happy to rip the TAINT parts out.  I was just hoping that some
tooling might pick up the taint flags today, and this could get picked
up without modification of whatever those tools are.

I was _really_ hoping the dmesg from the taint would be ugly and loud
enough to be sufficient, but it was relatively terse.

> A better option might be to declare known performance killers 
> in /proc/config_debug or so, and maybe print them once at the 
> end of the bootup, with a 'WARNING:' or 'INFO:' prefix. That 
> way tooling (benchmarks, profilers, etc.) can print them, but 
> it's also present in the syslog, just in case.

Sounds reasonable to me.  As long as we have _something_ that shows up
in dmesg, it will help.

  parent reply	other threads:[~2014-08-20 15:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20  3:57 [PATCH] [v2] TAINT_PERFORMANCE Dave Hansen
2014-08-20  3:57 ` Dave Hansen
2014-08-20  8:11 ` Ingo Molnar
2014-08-20  8:11   ` Ingo Molnar
2014-08-20 14:29   ` Josh Boyer
2014-08-20 14:29     ` Josh Boyer
2014-08-20 15:02   ` Dave Hansen [this message]
2014-08-20 15:02     ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F4B887.7060701@sr71.net \
    --to=dave@sr71.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=kirill@shutemov.name \
    --cc=lauraa@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.