All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: knut.omang@oracle.com, mst@redhat.com, weidong.huang@huawei.com,
	marcel.a@redhat.com
Subject: Re: [Qemu-devel] [PATCH] pcie: Fix incorrect write to device ctl2 register
Date: Thu, 21 Aug 2014 10:58:40 +0200	[thread overview]
Message-ID: <53F5B4C0.1080106@redhat.com> (raw)
In-Reply-To: <1408609864-16156-1-git-send-email-arei.gonglei@huawei.com>

Il 21/08/2014 10:31, arei.gonglei@huawei.com ha scritto:
> +++ b/hw/pci/pcie.c
> @@ -504,7 +504,7 @@ void pcie_cap_ari_init(PCIDevice *dev)
>      uint32_t pos = dev->exp.exp_cap;
>      pci_long_test_and_set_mask(dev->config + pos + PCI_EXP_DEVCAP2,
>                                 PCI_EXP_DEVCAP2_ARI);
> -    pci_long_test_and_set_mask(dev->wmask + pos + PCI_EXP_DEVCTL2,
> +    pci_long_test_and_set_mask(dev->config + pos + PCI_EXP_DEVCTL2,
>                                 PCI_EXP_DEVCTL2_ARI);
>  }
>  

IIUC the code is correct, it means that the bit can be written in
devctl2.  You don't want to set it, the firmware or OS can do it if they
understand ARI.

Paolo

  reply	other threads:[~2014-08-21  8:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21  8:31 [Qemu-devel] [PATCH] pcie: Fix incorrect write to device ctl2 register arei.gonglei
2014-08-21  8:58 ` Paolo Bonzini [this message]
2014-08-21  9:11   ` Gonglei (Arei)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F5B4C0.1080106@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=knut.omang@oracle.com \
    --cc=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weidong.huang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.