From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
To: "Murphy, Dan" <dmurphy-l0cyMroinI0@public.gmane.org>,
Dmitry Torokhov <dtor-JGs/UdohzUI@public.gmane.org>,
Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton
Date: Thu, 21 Aug 2014 12:19:39 -0500 [thread overview]
Message-ID: <53F62A2B.6010208@ti.com> (raw)
In-Reply-To: <00FC9A978A94B7418C33AFAE8A35ED49DF0662-l8PMxShYob2IQmiDNMet8wC/G2K4zDHf@public.gmane.org>
On 08/21/2014 11:59 AM, Murphy, Dan wrote:
[...]
Ooops.. missed answering one addition statement:
>> + of_property_read_u32(np, "ti,palmas-long-press-seconds", &val);
>
> Probably should check the return to make sure the value exists and that is is
> within an expected range.
It is an optional parameter and may not exist in dt. when it does
exist, the logic tries to do a best match (this is the for loop in the
logic just below).
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton
Date: Thu, 21 Aug 2014 12:19:39 -0500 [thread overview]
Message-ID: <53F62A2B.6010208@ti.com> (raw)
In-Reply-To: <00FC9A978A94B7418C33AFAE8A35ED49DF0662@DFLE09.ent.ti.com>
On 08/21/2014 11:59 AM, Murphy, Dan wrote:
[...]
Ooops.. missed answering one addition statement:
>> + of_property_read_u32(np, "ti,palmas-long-press-seconds", &val);
>
> Probably should check the return to make sure the value exists and that is is
> within an expected range.
It is an optional parameter and may not exist in dt. when it does
exist, the logic tries to do a best match (this is the for loop in the
logic just below).
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: "Murphy, Dan" <dmurphy@ti.com>, Dmitry Torokhov <dtor@mail.ru>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton
Date: Thu, 21 Aug 2014 12:19:39 -0500 [thread overview]
Message-ID: <53F62A2B.6010208@ti.com> (raw)
In-Reply-To: <00FC9A978A94B7418C33AFAE8A35ED49DF0662@DFLE09.ent.ti.com>
On 08/21/2014 11:59 AM, Murphy, Dan wrote:
[...]
Ooops.. missed answering one addition statement:
>> + of_property_read_u32(np, "ti,palmas-long-press-seconds", &val);
>
> Probably should check the return to make sure the value exists and that is is
> within an expected range.
It is an optional parameter and may not exist in dt. when it does
exist, the logic tries to do a best match (this is the for loop in the
logic just below).
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-08-21 17:19 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 20:13 [PATCH 0/2] Input: palmas: add support for palmas power button Nishanth Menon
2014-08-18 20:13 ` Nishanth Menon
2014-08-18 20:13 ` Nishanth Menon
2014-08-18 20:13 ` [PATCH 1/2] doc: dt/bindings: input: introduce palmas power button description Nishanth Menon
2014-08-18 20:13 ` Nishanth Menon
2014-08-18 20:13 ` Nishanth Menon
2014-08-19 5:28 ` Dmitry Torokhov
2014-08-19 5:28 ` Dmitry Torokhov
2014-08-19 10:23 ` Nishanth Menon
2014-08-19 10:23 ` Nishanth Menon
2014-08-18 20:13 ` [PATCH 2/2] Input: misc: introduce palmas-pwrbutton Nishanth Menon
2014-08-18 20:13 ` Nishanth Menon
2014-08-18 20:13 ` Nishanth Menon
2014-08-19 5:23 ` Dmitry Torokhov
2014-08-19 5:23 ` Dmitry Torokhov
2014-08-19 10:17 ` Nishanth Menon
2014-08-19 10:17 ` Nishanth Menon
2014-08-21 16:02 ` [PATCH V2 0/2] Input: palmas: add support for palmas power button Nishanth Menon
2014-08-21 16:02 ` Nishanth Menon
2014-08-21 16:02 ` Nishanth Menon
2014-08-21 16:02 ` [PATCH V2 1/2] doc: dt/bindings: input: introduce palmas power button description Nishanth Menon
2014-08-21 16:02 ` Nishanth Menon
2014-08-21 16:02 ` Nishanth Menon
2014-08-21 16:02 ` [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton Nishanth Menon
2014-08-21 16:02 ` Nishanth Menon
2014-08-21 16:02 ` Nishanth Menon
2014-08-21 16:59 ` Murphy, Dan
2014-08-21 16:59 ` Murphy, Dan
2014-08-21 17:12 ` Nishanth Menon
2014-08-21 17:12 ` Nishanth Menon
[not found] ` <00FC9A978A94B7418C33AFAE8A35ED49DF0662-l8PMxShYob2IQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2014-08-21 17:19 ` Nishanth Menon [this message]
2014-08-21 17:19 ` Nishanth Menon
2014-08-21 17:19 ` Nishanth Menon
2014-08-21 17:32 ` Murphy, Dan
2014-08-21 17:32 ` Murphy, Dan
[not found] ` <00FC9A978A94B7418C33AFAE8A35ED49DF07A2-l8PMxShYob2IQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2014-08-21 17:37 ` Nishanth Menon
2014-08-21 17:37 ` Nishanth Menon
2014-08-21 17:37 ` Nishanth Menon
2014-08-21 17:46 ` Murphy, Dan
2014-08-21 17:46 ` Murphy, Dan
2014-08-21 18:03 ` Dmitry Torokhov
2014-08-21 18:03 ` Dmitry Torokhov
2014-08-21 18:03 ` Dmitry Torokhov
2014-08-21 19:01 ` Nishanth Menon
2014-08-21 19:01 ` Nishanth Menon
2014-09-10 21:13 ` Dmitry Torokhov
2014-09-10 21:13 ` Dmitry Torokhov
2014-09-11 12:01 ` Nishanth Menon
2014-09-11 12:01 ` Nishanth Menon
2014-09-12 6:44 ` Dmitry Torokhov
2014-09-12 6:44 ` Dmitry Torokhov
2014-08-21 17:05 ` Dmitry Torokhov
2014-08-21 17:05 ` Dmitry Torokhov
2014-08-21 17:09 ` Nishanth Menon
2014-08-21 17:09 ` Nishanth Menon
[not found] ` <1408392810-16011-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-08-21 18:52 ` [PATCH V3 " Nishanth Menon
2014-08-21 18:52 ` Nishanth Menon
2014-08-21 18:52 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F62A2B.6010208@ti.com \
--to=nm-l0cymroini0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dmurphy-l0cyMroinI0@public.gmane.org \
--cc=dtor-JGs/UdohzUI@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.