From: Eric Blake <eblake@redhat.com>
To: Valentin Manea <valentin.manea@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: jia Liu <proljc@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/4] target-openrisc: Add LPC32XX touchscreen device
Date: Fri, 22 Aug 2014 11:36:49 -0600 [thread overview]
Message-ID: <53F77FB1.9090800@redhat.com> (raw)
In-Reply-To: <53F77893.4050609@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
[meta-comment]
On 08/22/2014 11:06 AM, Valentin Manea wrote:
> The LPC32XX is a simple MMIO touch screen device with a Linux device
> driver. The device is suitable for small machines which require mouse
> input but have no suitable bus(SPI, I2C).
You did deep threading (patch 4 was in-reply to all four of 0/4, 1/4,
2/4, and 3/4):
0/4
+ 1/4
+ 2/4
+ 3/4
+ 4/4
which leads to awkward review tree layouts in many mailers (where the
algorithm is to list all message in-reply-to to a common parent in date
order):
0/4
+ 1/4
+ 2/4
| + 3/4
| | + 4/4
| | | + Re: 4/4
| | + Re: 3/4
| + Re: 2/4
+ Re: 1/4
We prefer shallow threading (git send-email's default, if you don't mess
with configuration variables, where patch 4 is in-reply-to _only_ 0/4):
0/4
+ 1/4
+ 2/4
+ 3/4
+ 4/4
which also leads to nicer review tree layouts:
0/4
+ 1/4
| + Re: 1/4
+ 2/4
| + Re: 2/4
+ 3/4
| + Re: 3/4
+ 4/4
+ Re: 4/4
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-08-22 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 17:00 [Qemu-devel] [PATCH v2 0/4] target-openrisc: Machine improvements take two Valentin Manea
2014-08-22 17:02 ` [Qemu-devel] [PATCH v2 1/4] target-openrisc: Add IDE support to default machine Valentin Manea
2014-08-22 17:04 ` [Qemu-devel] [PATCH v2 2/4] target-openrisc: Add OpenCores FB device support Valentin Manea
2014-08-22 17:04 ` Valentin Manea
2014-08-22 17:05 ` [Qemu-devel] [PATCH v2 3/4] target-openrisc: Add OpenCores keyboard " Valentin Manea
2014-08-22 17:06 ` [Qemu-devel] [PATCH v2 4/4] target-openrisc: Add LPC32XX touchscreen device Valentin Manea
2014-08-22 17:36 ` Eric Blake [this message]
2014-08-22 18:33 ` Valentin Manea
2014-08-25 1:38 ` Jia Liu
2014-08-25 1:36 ` [Qemu-devel] [PATCH v2 3/4] target-openrisc: Add OpenCores keyboard device support Jia Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F77FB1.9090800@redhat.com \
--to=eblake@redhat.com \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=valentin.manea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.