From: addy ke <addy.ke@rock-chips.com>
To: dianders@chromium.org
Cc: huangtao@rock-chips.com, dmitry.torokhov@gmail.com,
heiko@sntech.de, sergei.shtylyov@cogentembedded.com,
wsa@the-dreams.de, yzq@rock-chips.com, zyw@rock-chips.com,
max.schwarz@online.de, linux-kernel@vger.kernel.org,
kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org,
xjq@rock-chips.com, linux-i2c@vger.kernel.org,
caesar.wang@rock-chips.com, olof@lixom.net, cf@rock-chips.com,
hj@rock-chips.com, zhengsq@rock-chips.com,
linux-arm-kernel@lists.infradead.org, hl@rock-chips.com
Subject: Re: [PATCH v4] i2c: rk3x: fix bug that cause transfer fails in master receive mode
Date: Sat, 23 Aug 2014 02:47:34 +0800 [thread overview]
Message-ID: <53F79046.5020803@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=Vof8mOmCHkRyrhjGBewJqJaCu==1RfUZ+8C9Jm+UH50w@mail.gmail.com>
> Addy,
>
> On Fri, Aug 22, 2014 at 11:00 AM, Addy Ke <addy.ke@rock-chips.com> wrote:
>> In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data
>> in one chunk, so the size of data to be write/read to/from TXDATAx/RXDATAx
>> must be less than or equal 32 bytes at a time.
>>
>> Tested on rk3288-pinky board, elan receive 158 bytes data.
>>
>> Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> You only need a "Suggested-by" if the entire patch was suggested by
> someone. If someone provides you review feedback you don't need it.
>
> Said another way: in this case Dmitry didn't suggest that you need to
> fix the i2c controller to transmit 32 byte chunks (he only provided
> review feedback), so you shouldn't say this was Suggested-by him.
>
> You also had my reviewed-by on a previous version so you could keep it.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
so, Do I need repost this patch or post a new one as patch v5?
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: addy.ke@rock-chips.com (addy ke)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] i2c: rk3x: fix bug that cause transfer fails in master receive mode
Date: Sat, 23 Aug 2014 02:47:34 +0800 [thread overview]
Message-ID: <53F79046.5020803@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=Vof8mOmCHkRyrhjGBewJqJaCu==1RfUZ+8C9Jm+UH50w@mail.gmail.com>
> Addy,
>
> On Fri, Aug 22, 2014 at 11:00 AM, Addy Ke <addy.ke@rock-chips.com> wrote:
>> In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data
>> in one chunk, so the size of data to be write/read to/from TXDATAx/RXDATAx
>> must be less than or equal 32 bytes at a time.
>>
>> Tested on rk3288-pinky board, elan receive 158 bytes data.
>>
>> Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> You only need a "Suggested-by" if the entire patch was suggested by
> someone. If someone provides you review feedback you don't need it.
>
> Said another way: in this case Dmitry didn't suggest that you need to
> fix the i2c controller to transmit 32 byte chunks (he only provided
> review feedback), so you shouldn't say this was Suggested-by him.
>
> You also had my reviewed-by on a previous version so you could keep it.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
so, Do I need repost this patch or post a new one as patch v5?
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: addy ke <addy.ke@rock-chips.com>
To: dianders@chromium.org
Cc: wsa@the-dreams.de, max.schwarz@online.de, heiko@sntech.de,
olof@lixom.net, dmitry.torokhov@gmail.com,
sergei.shtylyov@cogentembedded.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, cf@rock-chips.com,
xjq@rock-chips.com, huangtao@rock-chips.com, zyw@rock-chips.com,
yzq@rock-chips.com, hj@rock-chips.com, kever.yang@rock-chips.com,
hl@rock-chips.com, caesar.wang@rock-chips.com,
zhengsq@rock-chips.com
Subject: Re: [PATCH v4] i2c: rk3x: fix bug that cause transfer fails in master receive mode
Date: Sat, 23 Aug 2014 02:47:34 +0800 [thread overview]
Message-ID: <53F79046.5020803@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=Vof8mOmCHkRyrhjGBewJqJaCu==1RfUZ+8C9Jm+UH50w@mail.gmail.com>
> Addy,
>
> On Fri, Aug 22, 2014 at 11:00 AM, Addy Ke <addy.ke@rock-chips.com> wrote:
>> In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data
>> in one chunk, so the size of data to be write/read to/from TXDATAx/RXDATAx
>> must be less than or equal 32 bytes at a time.
>>
>> Tested on rk3288-pinky board, elan receive 158 bytes data.
>>
>> Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> You only need a "Suggested-by" if the entire patch was suggested by
> someone. If someone provides you review feedback you don't need it.
>
> Said another way: in this case Dmitry didn't suggest that you need to
> fix the i2c controller to transmit 32 byte chunks (he only provided
> review feedback), so you shouldn't say this was Suggested-by him.
>
> You also had my reviewed-by on a previous version so you could keep it.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
so, Do I need repost this patch or post a new one as patch v5?
>
>
>
next prev parent reply other threads:[~2014-08-22 18:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0001-i2c-rk3x-fix-bug-that-cause-transfer-fails-in-master.patch>
2014-08-21 21:38 ` [PATCH v2] i2c: rk3x: fix bug that cause transfer fails in maste receive mode Addy Ke
2014-08-21 21:38 ` Addy Ke
[not found] ` <1408657107-8715-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-08-22 1:13 ` [PATCH v3] i2c: rk3x: fix bug that cause transfer fails in master " Addy Ke
2014-08-22 1:13 ` Addy Ke
2014-08-22 1:13 ` Addy Ke
[not found] ` <1408669991-9703-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-08-22 1:15 ` Doug Anderson
2014-08-22 1:15 ` Doug Anderson
2014-08-22 1:15 ` Doug Anderson
2014-08-22 16:16 ` Dmitry Torokhov
2014-08-22 16:16 ` Dmitry Torokhov
2014-08-22 16:16 ` Dmitry Torokhov
2014-08-22 18:00 ` [PATCH v4] " Addy Ke
2014-08-22 18:00 ` Addy Ke
2014-08-22 18:00 ` Addy Ke
[not found] ` <1408730452-3552-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-08-22 18:33 ` Doug Anderson
2014-08-22 18:33 ` Doug Anderson
2014-08-22 18:33 ` Doug Anderson
2014-08-22 18:47 ` addy ke [this message]
2014-08-22 18:47 ` addy ke
2014-08-22 18:47 ` addy ke
2014-08-22 20:04 ` Doug Anderson
2014-08-22 20:04 ` Doug Anderson
2014-09-02 11:01 ` Wolfram Sang
2014-09-02 11:01 ` Wolfram Sang
2014-09-02 11:01 ` Wolfram Sang
2014-08-22 1:14 ` [PATCH v2] i2c: rk3x: fix bug that cause transfer fails in maste " Doug Anderson
2014-08-22 1:14 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F79046.5020803@rock-chips.com \
--to=addy.ke@rock-chips.com \
--cc=caesar.wang@rock-chips.com \
--cc=cf@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=hj@rock-chips.com \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=max.schwarz@online.de \
--cc=olof@lixom.net \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa@the-dreams.de \
--cc=xjq@rock-chips.com \
--cc=yzq@rock-chips.com \
--cc=zhengsq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.