[lm-sensors] [PATCH] hwmon: (ds1621) Update zbits after conversion rate change

[lm-sensors] [PATCH] hwmon: (ds1621) Update zbits after conversion rate change

[rob.coulson]

From: Robert Coulson <rob.coulson@gmail.com>

After the conversion rate is changed, the zbits are not updated,
but should be, since they are used later in the set_temp function.

This issue was noticed and reported by Murat Ilsever.

Signed-off-by: Robert Coulson <rob.coulson@gmail.com>
---
 drivers/hwmon/ds1621.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/hwmon/ds1621.c b/drivers/hwmon/ds1621.c
index 872d767..b96d201 100644
--- a/drivers/hwmon/ds1621.c
+++ b/drivers/hwmon/ds1621.c
@@ -309,6 +309,7 @@ static ssize_t set_convrate(struct device *dev, struct device_attribute *da,
 	data->conf |= (resol << DS1621_REG_CONFIG_RESOL_SHIFT);
 	i2c_smbus_write_byte_data(client, DS1621_REG_CONF, data->conf);
 	data->update_interval = ds1721_convrates[resol];
+	data->zbits = 7 - resol;
 	mutex_unlock(&data->update_lock);
 
 	return count;
-- 
1.7.3.1


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (ds1621) Update zbits after conversion rate change

[Guenter Roeck]

On 08/22/2014 12:28 PM, rob.coulson@gmail.com wrote:
> From: Robert Coulson <rob.coulson@gmail.com>
>
> After the conversion rate is changed, the zbits are not updated,
> but should be, since they are used later in the set_temp function.
>
> This issue was noticed and reported by Murat Ilsever.

Hi Rob,

good catch. Can you add the reporter with a Reported-by: tag
to give proper credit ?

Also, if possible, it would be great if you can add a Fixes: tag
showing the commit causing the problem. Search for existing Fixes:
tags to see how it is done.

Thanks,
Guenter

>
> Signed-off-by: Robert Coulson <rob.coulson@gmail.com>
> ---
>   drivers/hwmon/ds1621.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hwmon/ds1621.c b/drivers/hwmon/ds1621.c
> index 872d767..b96d201 100644
> --- a/drivers/hwmon/ds1621.c
> +++ b/drivers/hwmon/ds1621.c
> @@ -309,6 +309,7 @@ static ssize_t set_convrate(struct device *dev, struct device_attribute *da,
>   	data->conf |= (resol << DS1621_REG_CONFIG_RESOL_SHIFT);
>   	i2c_smbus_write_byte_data(client, DS1621_REG_CONF, data->conf);
>   	data->update_interval = ds1721_convrates[resol];
> +	data->zbits = 7 - resol;
>   	mutex_unlock(&data->update_lock);
>
>   	return count;
>


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (ds1621) Update zbits after conversion rate change

[Robert Coulson]

Good morning Guenter and thank you for taking the time to review this
patch, I appreciate it.

Yes, I will add the Reported-by and Fixes lines, then resend the updated
patch.

thanks again,

*** Rob.


On Sat, Aug 23, 2014 at 8:13 AM, Guenter Roeck <linux@roeck-us.net> wrote:

> On 08/22/2014 12:28 PM, rob.coulson@gmail.com wrote:
>
>> From: Robert Coulson <rob.coulson@gmail.com>
>>
>> After the conversion rate is changed, the zbits are not updated,
>> but should be, since they are used later in the set_temp function.
>>
>> This issue was noticed and reported by Murat Ilsever.
>>
>
> Hi Rob,
>
> good catch. Can you add the reporter with a Reported-by: tag
> to give proper credit ?
>
> Also, if possible, it would be great if you can add a Fixes: tag
> showing the commit causing the problem. Search for existing Fixes:
> tags to see how it is done.
>
> Thanks,
> Guenter
>
>
>
>> Signed-off-by: Robert Coulson <rob.coulson@gmail.com>
>> ---
>>   drivers/hwmon/ds1621.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/hwmon/ds1621.c b/drivers/hwmon/ds1621.c
>> index 872d767..b96d201 100644
>> --- a/drivers/hwmon/ds1621.c
>> +++ b/drivers/hwmon/ds1621.c
>> @@ -309,6 +309,7 @@ static ssize_t set_convrate(struct device *dev,
>> struct device_attribute *da,
>>         data->conf |= (resol << DS1621_REG_CONFIG_RESOL_SHIFT);
>>         i2c_smbus_write_byte_data(client, DS1621_REG_CONF, data->conf);
>>         data->update_interval = ds1721_convrates[resol];
>> +       data->zbits = 7 - resol;
>>         mutex_unlock(&data->update_lock);
>>
>>         return count;
>>
>>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors