Re: [PATCH net-next v3 04/12] net: dsa: retain a per-port device_node pointer

[Alexander Duyck <alexander.duyck@gmail.com>]

On 08/24/2014 11:44 AM, Florian Fainelli wrote:
> We will later use the per-port device_node pointer to fetch a bunch of
> port-specific properties.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  include/net/dsa.h | 1 +
>  net/dsa/dsa.c     | 2 ++
>  net/dsa/slave.c   | 1 +
>  3 files changed, 4 insertions(+)
>
> diff --git a/include/net/dsa.h b/include/net/dsa.h
> index 91d5ba435ab6..66bb036831fd 100644
> --- a/include/net/dsa.h
> +++ b/include/net/dsa.h
> @@ -41,6 +41,7 @@ struct dsa_chip_data {
>  	 * or any other string to indicate this is a physical port.
>  	 */
>  	char		*port_names[DSA_MAX_PORTS];
> +	struct device_node *port_dn[DSA_MAX_PORTS];
>  
>  	/*
>  	 * An array (with nr_chips elements) of which element [a]

It might make sense to place name and device_node pointers members of a
port struct, and move that array of structs to the end of the
dsa_chip_data structure.

Thanks,

ALex