All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Cc: davem@davemlof.net, jhs@mojatatu.com, linville@tuxdriver.com,
	alexander.h.duyck@intel.com
Subject: Re: [PATCH net-next v3 08/12] net: dsa: allow updating fixed PHY link information
Date: Mon, 25 Aug 2014 23:33:24 +0400	[thread overview]
Message-ID: <53FB8F84.20208@cogentembedded.com> (raw)
In-Reply-To: <1408905869-10471-9-git-send-email-f.fainelli@gmail.com>

Hello.

On 08/24/2014 10:44 PM, Florian Fainelli wrote:

> Allow switch drivers to hook a PHY link update callback to perform
> port-specific link work.

> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

[...]

> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 893afe9e60aa..ee019ec29dec 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
[...]
> @@ -389,6 +401,7 @@ static void dsa_slave_phy_setup(struct dsa_slave_priv *p,
>   	struct dsa_switch *ds = p->parent;
>   	struct dsa_chip_data *cd = ds->pd;
>   	struct device_node *phy_dn, *port_dn;
> +	unsigned int phy_is_fixed = 0;

    Why not *bool*?

[...]

WBR, Sergei

  parent reply	other threads:[~2014-08-25 19:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-24 18:44 [PATCH net-next v3 00/12] dsa: support for Broadcom Starfighter 2 Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 01/12] net: dsa: rework skb->protocol override helpers Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 02/12] net: phy: add generic UniMAC MDIO bus driver Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 03/12] net: dsa: provide a switch device device tree node pointer Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 04/12] net: dsa: retain a per-port device_node pointer Florian Fainelli
2014-08-24 23:32   ` Alexander Duyck
2014-08-25  2:30     ` Florian Fainelli
2014-08-26  0:51       ` Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 05/12] net: dsa: allow for more complex PHY setups Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 06/12] net: dsa: allow switches to work without tagging Florian Fainelli
2014-08-24 23:27   ` Alexander Duyck
2014-08-24 18:44 ` [PATCH net-next v3 07/12] net: dsa: allow drivers to do link adjustment Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 08/12] net: dsa: allow updating fixed PHY link information Florian Fainelli
2014-08-25  4:56   ` David Miller
2014-08-25 19:33   ` Sergei Shtylyov [this message]
2014-08-24 18:44 ` [PATCH net-next v3 09/12] net: dsa: add Broadcom tag RX/TX handler Florian Fainelli
2014-08-24 22:51   ` Alexander Duyck
2014-08-25  2:37     ` Florian Fainelli
2014-08-25 14:51       ` Alexander Duyck
2014-08-24 18:44 ` [PATCH net-next v3 10/12] net: dsa: add Broadcom SF2 switch driver Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 11/12] Documentation: devicetree: update dsa binding with optional properties Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 12/12] Documentation: devicetree: add Broadcom Starfighter 2 binding Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FB8F84.20208@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemlof.net \
    --cc=f.fainelli@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.