All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Musta <tommusta@gmail.com>
To: Stefan Weil <sw@weilnetz.de>, Michael Tokarev <mjt@tls.msk.ru>,
	 qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] libdecnumber: Fix warnings from smatch (missing static, boolean operations)
Date: Mon, 25 Aug 2014 08:49:08 -0500	[thread overview]
Message-ID: <53FB3ED4.2000902@gmail.com> (raw)
In-Reply-To: <53F9B372.10602@weilnetz.de>

On 8/24/2014 4:42 AM, Stefan Weil wrote:
> Am 24.08.2014 11:21, schrieb Michael Tokarev:
>> Applied to -trivial, thank you!
>>
>> But I've a small concern - should we really do this on "external" sources,
>> and divirge from upstream needlessly?
>>
>> Thanks,
>>
>> /mjt
> 
> In general, I agree. In this case, the code was part of gcc, and newer versions of gcc use GPL 3 which is incompatible with QEMU, so I assume that the code in QEMU is no longer available from a maintained upstream.
> 
> Stefan
> 
> 
> 

Yes.  We had to effectively fork a copy the code to deal with the license issues.

FWIW ... Alex has suggested a reformat of the libdecnumber code to make it compatible with QEMU formatting (http://lists.nongnu.org/archive/html/qemu-ppc/2014-05/msg00085.html).  This is on my todo list.  Obviously, such a reformat would make it even
harder to synchronize with upstream gcc.



WARNING: multiple messages have this Message-ID (diff)
From: Tom Musta <tommusta@gmail.com>
To: Stefan Weil <sw@weilnetz.de>, Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] libdecnumber: Fix warnings from smatch (missing static, boolean operations)
Date: Mon, 25 Aug 2014 08:49:08 -0500	[thread overview]
Message-ID: <53FB3ED4.2000902@gmail.com> (raw)
In-Reply-To: <53F9B372.10602@weilnetz.de>

On 8/24/2014 4:42 AM, Stefan Weil wrote:
> Am 24.08.2014 11:21, schrieb Michael Tokarev:
>> Applied to -trivial, thank you!
>>
>> But I've a small concern - should we really do this on "external" sources,
>> and divirge from upstream needlessly?
>>
>> Thanks,
>>
>> /mjt
> 
> In general, I agree. In this case, the code was part of gcc, and newer versions of gcc use GPL 3 which is incompatible with QEMU, so I assume that the code in QEMU is no longer available from a maintained upstream.
> 
> Stefan
> 
> 
> 

Yes.  We had to effectively fork a copy the code to deal with the license issues.

FWIW ... Alex has suggested a reformat of the libdecnumber code to make it compatible with QEMU formatting (http://lists.nongnu.org/archive/html/qemu-ppc/2014-05/msg00085.html).  This is on my todo list.  Obviously, such a reformat would make it even
harder to synchronize with upstream gcc.

  parent reply	other threads:[~2014-08-25 13:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20  9:02 [Qemu-trivial] [PATCH] libdecnumber: Fix warnings from smatch (missing static, boolean operations) Stefan Weil
2014-08-20  9:02 ` [Qemu-devel] " Stefan Weil
2014-08-24  9:21 ` [Qemu-trivial] " Michael Tokarev
2014-08-24  9:21   ` [Qemu-devel] " Michael Tokarev
2014-08-24  9:42   ` Stefan Weil
2014-08-24  9:42     ` [Qemu-devel] " Stefan Weil
2014-08-25  7:40     ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2014-08-25  7:40       ` [Qemu-devel] [Qemu-trivial] " Markus Armbruster
2014-08-25 13:49     ` Tom Musta [this message]
2014-08-25 13:49       ` Tom Musta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FB3ED4.2000902@gmail.com \
    --to=tommusta@gmail.com \
    --cc=agraf@suse.de \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.