Re: [PATCH] fbdev: Remove __init from chips_hw_init() to fix build failure

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

On 21/08/14 15:23, Pranith Kumar wrote:
> Fix build failure caused as follows:
> 
> The function chipsfb_pci_init() references
> the function __init chips_hw_init().
> This is often because chipsfb_pci_init lacks a __init 
> annotation or the annotation of chips_hw_init is wrong.
> 
> make: *** [drivers] Error 2
> 
> by removing the __init annotation from chips_hw_init(). The other thing that
> could have been done was annotating chipsfb_pci_init(). But that cannot be done
> since chipsfb_pci_init() is called from non __init functions.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
>  drivers/video/fbdev/chipsfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
> index 206a66b..59abdc6 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -273,7 +273,7 @@ static struct chips_init_reg chips_init_xr[] = {
>  	{ 0xa8, 0x00 }
>  };
>  
> -static void __init chips_hw_init(void)
> +static void chips_hw_init(void)
>  {
>  	int i;
>  
> 

Thanks, queued for 3.17 fbdev fixes.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]