From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Thomas Winischhofer <thomas@winischhofer.net>,
Joe Perches <joe@perches.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] video: fbdev: sis: delete double assignment
Date: Tue, 26 Aug 2014 10:51:57 +0000 [thread overview]
Message-ID: <53FC66CD.8040800@ti.com> (raw)
In-Reply-To: <CAMuHMdVERt9XBN5OW8QqT_PvQVHd6xgnCdjRpiSNp7ZSEgXWSg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On 24/08/14 21:21, Geert Uytterhoeven wrote:
> On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>> ---
>> The patches in this series do not depend on each other.
>>
>> This changes the semantics of the code and is not tested.
>
> Hence I think you should change the subject of the patch, so it's obvious
> some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment".
Well, to me "fix double assignment" sounds the same as "delete double
assignment".
Looking at the code, I think what's done here is "fix 1280x768 panel
timings".
I can apply this and do the change to subject, if nobody complains.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Thomas Winischhofer <thomas@winischhofer.net>,
Joe Perches <joe@perches.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] video: fbdev: sis: delete double assignment
Date: Tue, 26 Aug 2014 13:51:57 +0300 [thread overview]
Message-ID: <53FC66CD.8040800@ti.com> (raw)
In-Reply-To: <CAMuHMdVERt9XBN5OW8QqT_PvQVHd6xgnCdjRpiSNp7ZSEgXWSg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On 24/08/14 21:21, Geert Uytterhoeven wrote:
> On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>> ---
>> The patches in this series do not depend on each other.
>>
>> This changes the semantics of the code and is not tested.
>
> Hence I think you should change the subject of the patch, so it's obvious
> some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment".
Well, to me "fix double assignment" sounds the same as "delete double
assignment".
Looking at the code, I think what's done here is "fix 1280x768 panel
timings".
I can apply this and do the change to subject, if nobody complains.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-26 10:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 18:33 [PATCH 0/7] delete double assignment Julia Lawall
2014-08-23 18:33 ` Julia Lawall
2014-08-23 18:33 ` [PATCH 1/7] video: fbdev: riva: " Julia Lawall
2014-08-23 18:33 ` Julia Lawall
2014-08-23 18:33 ` [PATCH 2/7] video: fbdev: intelfb: " Julia Lawall
2014-08-23 18:33 ` Julia Lawall
2014-08-26 10:56 ` Tomi Valkeinen
2014-08-26 10:56 ` Tomi Valkeinen
2014-08-23 18:33 ` [PATCH 3/7] serial: vr41xx_siu: " Julia Lawall
2014-08-23 18:33 ` Julia Lawall
2014-08-23 18:33 ` [PATCH 4/7] MIPS: BCM63xx: " Julia Lawall
2014-08-23 18:33 ` Julia Lawall
2014-08-25 11:27 ` Ralf Baechle
2014-08-25 11:27 ` Ralf Baechle
2014-08-25 19:09 ` Jonas Gorski
2014-08-25 19:09 ` Jonas Gorski
2014-08-23 18:33 ` [PATCH 5/7] wusb: " Julia Lawall
2014-08-23 18:33 ` Julia Lawall
2014-08-23 18:33 ` [PATCH 6/7] video: fbdev: sis: " Julia Lawall
2014-08-23 18:33 ` Julia Lawall
2014-08-24 18:21 ` Geert Uytterhoeven
2014-08-24 18:21 ` Geert Uytterhoeven
2014-08-24 18:40 ` Julia Lawall
2014-08-24 18:40 ` Julia Lawall
2014-08-25 11:36 ` Geert Uytterhoeven
2014-08-25 11:36 ` Geert Uytterhoeven
2014-08-26 10:51 ` Tomi Valkeinen [this message]
2014-08-26 10:51 ` Tomi Valkeinen
2014-08-23 18:33 ` [PATCH 7/7] MIPS: Alchemy: au1200fb: " Julia Lawall
2014-08-23 18:33 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC66CD.8040800@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=Julia.Lawall@lip6.fr \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.